Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExecuteOnMainThread.cs to work with newer versions of .NET #218

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

matronator
Copy link

Remove #if NET_40 to make it work on newer versions of .NET.

Remove `#if NET_40` to make it work on newer versions of .NET.
@maifeeulasad maifeeulasad self-assigned this May 30, 2022
@maifeeulasad
Copy link
Collaborator

maifeeulasad commented May 30, 2022

Hey @matronator, really appreciate your effort toward this proyecto26-RestClient library and open source. A warm welcome from the proyecto26-RestClient team.

Now,

As per this official support thread, Unity supports Unity 2018.4 (LTS) and onward. And this thread is from 2021-05-04.

unity supported list

And as per this documentation:

... In Unity 2018.1, the .NET 4.x equivalent runtime is no longer considered experimental, while the older .NET 3.5 equivalent runtime is now considered to be the legacy version. And with the release of Unity 2018.3, Unity is projecting to make the upgraded scripting runtime the default selection, ...

So there remains a huge question, should we even support older versions?

Really eager to hear back your thoughts on this.

Thanks.

@matronator
Copy link
Author

matronator commented May 30, 2022

Hi, thanks for the welcome!

Hmm, didn't know that, I knew there's gotta be some reason for the #ifs to be there.

Well, what if instead of dropping support, we could just add additional #ifs for newer versions of .NET (though it'd be a bit cumbersome and had to be updated every time a new version comes along - though that shouldn't be too much often).

Alternatively, I don't suppose there is some way you can have multiple versions of the same package on the Unity Asset Store, is it? So you could have one version with the #if that supports the older versions of Unity and a second version without it for 2018.4 and later.

@maifeeulasad maifeeulasad requested a review from jdnichollsc June 17, 2022 06:40
@maifeeulasad maifeeulasad removed their assignment Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants