Move to Array API version 2023.12. #696
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
- Coverage 90.21% 89.36% -0.86%
==========================================
Files 20 23 +3
Lines 3670 3809 +139
==========================================
+ Hits 3311 3404 +93
- Misses 359 405 +46 |
hameerabbasi
force-pushed
the
array-api-2023.12
branch
from
9d2ef8b to
59daf9d
Compare
sparse/numba_backend/_info.py
Outdated
There was a problem hiding this comment.
I think we want to test these functions. Let's add simple tests, like in NumPy: https://github.com/numpy/numpy/pull/26572/files#diff-db073cec9b943fac08cf9720c471d90dcbb7a0e00f4717433314ec95bee60fe2
| return x.astype(dtype, copy=copy) | ||
|
|
||
|
|
||
| def unstack(x, /, *, axis=0): |
There was a problem hiding this comment.
I think unstack is new - let's add a test for it.
sparse/numba_backend/__init__.py
Outdated
| @@ -157,10 +165,16 @@ | |||
| where, | |||
| ) | |||
| from ._dok import DOK | |||
| from ._info import capabilities, default_device, default_dtypes, devices, dtypes | |||
There was a problem hiding this comment.
I think we shouldn't import them to the main namespace. Let's keep them in __array_namespace_info__ only.
There was a problem hiding this comment.
The current array API tests require these in the main namespace as well.
There was a problem hiding this comment.
Hmm then I think it's a bug in the array-api-tests suite.
There was a problem hiding this comment.
Array API standard doesn't say they need to be in the main namespace: https://data-apis.org/array-api/latest/API_specification/inspection.html#inspection-apis
There was a problem hiding this comment.
Demonstrated the failure in 42c9bfd, let's wait for array-api-tests fixes as you suggest.
|
Let's put this back as draft until the different signature for |
No description provided.