-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add doctests to CI again. #767
Conversation
3e192f9
to
f2b830d
Compare
CodSpeed Performance ReportMerging #767 will degrade performances by 41.43%Comparing Summary
Benchmarks breakdown
|
@willow-ahrens Doctest issue. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
using numba from the numba channel (with a statically linked llvmlite) fixes the segfault issue on mac. It appears that the segfault issue is mac-only at this point, as linux supports some special symbol resolution thing that fixed this problem. Proposed solution: I would like to leave a warning to users on startup in the event that they have tried to load this particular config of packages. I think we could warn in pydata/sparse whenever we see (conda in use) AND (macos) AND (numba was not installed from numba channel) As a side note: it is odd to me that we are loading both numba and finch at the same time. we might reduce some of this headache by switching between backends as a build option, rather than a runtime option. |
I cannot get a reproducer for this in docker, though I have tried. If anyone can get a reproducer for this that would be great, then we can put it in an issue where we describe the problem. If you ssh into the CI runner, even doing "import sparse.finch_backend" will segfault, so we don't need all the pytest stuff to reproduce. |
e2f2372
to
043bc00
Compare
043bc00
to
9015436
Compare
9015436
to
e8c01a7
Compare
351cd31
to
c07ab6d
Compare
c07ab6d
to
e86fc3a
Compare
I've put a comment in to pyjuliapackage that we experience an issue with parallel installs, and suggested a fix here: JuliaPy/pyjuliapkg#19 |
also, note this comment regarding installation of juliacall and numba on conda: JuliaPy/PythonCall.jl#215 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question.
And please remember about a commit squash! |
What type of PR is this? (check all applicable)
Related issues
Checklist
Please explain your changes below.