Render docstrings and datatable cells with example table entries #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t like step names currently are.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 95.95% 96.01% +0.06%
==========================================
Files 55 55
Lines 2200 2211 +11
Branches 242 244 +2
==========================================
+ Hits 2111 2123 +12
+ Misses 54 53 -1
Partials 35 35 ☔ View full report in Codecov by Sentry. |
vianney-g
reviewed
Nov 28, 2024
|
hey I took the liberty of applying some changes directly, hope you don't mind. If that's fine to you, I'd merge it. |
youtux
previously approved these changes
Nov 30, 2024
The regex is no longer just for steps
Not at all! I did notice when I code reviewed that the STEP_PARAM_RE regex is no longer just for steps so renamed it. |
|
I can't merge :(. Sorry my new commit invalidated your approval @youtux |
|
turns out that the |
youtux
approved these changes
Nov 30, 2024
youtux
deleted the
render-docstrings-and-datatables-with-example-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render scenario names, docstrings and datatable cells with example table entries, just like step names currently are.
Fixed another issue that I hadn't seen before that background steps were also not able to be rendered using the current logic. This is now fixed.
Resolves #741
Resolves #252