-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty example table entries with converter to None documentation #747
Conversation
…example tables works as expected Resolves #551
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 55 55
Lines 2244 2244
Branches 246 246
=======================================
Hits 2156 2156
Misses 53 53
Partials 35 35 ☔ View full report in Codecov by Sentry. |
@youtux Could you review and see if this is clear/correct/helpful? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need a test for this? isn't this tested somewhere else already? Maybe not this very example, but the fact that converters... basically work.
Good point. I'll just add to the docs |
Add documentation for parser converter for empty strings in example tables.
Resolves #551