Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty example table entries with converter to None documentation #747

Merged
merged 5 commits into from
Dec 1, 2024

Conversation

jsa34
Copy link
Collaborator

@jsa34 jsa34 commented Nov 30, 2024

Add documentation for parser converter for empty strings in example tables.

Resolves #551

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (d527a67) to head (e181ced).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #747   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          55       55           
  Lines        2244     2244           
  Branches      246      246           
=======================================
  Hits         2156     2156           
  Misses         53       53           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsa34
Copy link
Collaborator Author

jsa34 commented Dec 1, 2024

@youtux Could you review and see if this is clear/correct/helpful?

youtux
youtux previously approved these changes Dec 1, 2024
Copy link
Contributor

@youtux youtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need a test for this? isn't this tested somewhere else already? Maybe not this very example, but the fact that converters... basically work.

@jsa34
Copy link
Collaborator Author

jsa34 commented Dec 1, 2024

Good point. I'll just add to the docs

@jsa34 jsa34 changed the title Empty example table entries with converter to None test Empty example table entries with converter to None documentation Dec 1, 2024
@youtux youtux merged commit be83407 into master Dec 1, 2024
18 checks passed
@youtux youtux deleted the test-551 branch December 1, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New pytest bdd 6.0.1 doesnt take null values from the Examples within the scenario outline
2 participants