use Contextmanagers to handle StopIteration in generators #12934
+104
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it turns out, StopIteration is not transparent on the boundaries of generators
Tusenka
approved these changes
Dec 9, 2024
|
src/_pytest/threadexception.py and src/_pytest/unraisableexception.py both use regular trylast hooks instead of generators, so the conflicts can be resolved by checking them out from main |
graingert
reviewed
Dec 19, 2024
| @@ -0,0 +1,87 @@ | |||
| """ | |||
| test example file exposing mltiple issues with corutine exception passover in case of stopiteration | |||
There was a problem hiding this comment.
Suggested change
| test example file exposing mltiple issues with corutine exception passover in case of stopiteration | |
| test example file exposing multiple issues with coroutine exception passover in case of stopiteration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yield from is a generator boundary that transfers StopIteration into a RuntimeError
closes #12929