Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128152: Update Argument Clinic to support empty lines #128158

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Dec 21, 2024

This will skip the logic that follows after for empty lines so there should be no error. Assert is now no longer needed.

I don't this a NEWS worthy PR? If it is I can add an entry but I think a Skip NEWS label is just fine.

Copy link
Contributor

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's the proper approach, although it may work. Empty lines could be incorrect directives depending on the DSL. In addition, please add tests for python input directives and for pure clinic directives to see if something changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants