gh-128302: fix apparent bug in xml.dom.xmlbuilder.DOMBuilder.parse()
#128284
+8
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a bug. The
Options
class has nosystemId
attribute, but the input parameter, which seems to be an instance ofDOMInputSource
, does.I don't really know how this is meant to be used, but given this code:
As-is this raises an error:
With this change:
I'd consider adding a test, but there's no tests right now for any of this.
xml.dom.xmlbuilder.DOMBuilder.parse()
#128302