Mention loop_factory argument in docstring for asyncio.run() #128288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
requested review from
1st1,
kumaraditya303 and
willingc
as code owners
asvetlov
added
type-bug
kumaraditya303
approved these changes
Dec 27, 2024
|
Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2024
…H-128288) (cherry picked from commit 0b5f1fa) Co-authored-by: Andrew Svetlov <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2024
…H-128288) (cherry picked from commit 0b5f1fa) Co-authored-by: Andrew Svetlov <[email protected]>
|
GH-128291 is a backport of this pull request to the 3.13 branch. |
|
GH-128292 is a backport of this pull request to the 3.12 branch. |
asvetlov
added a commit
that referenced
this pull request
Dec 27, 2024
…H-128288) (#128292) Mention loop_factory argument in docstring for asyncio.run() (GH-128288) (cherry picked from commit 0b5f1fa) Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Dec 27, 2024
…H-128288) (#128291) Mention loop_factory argument in docstring for asyncio.run() (GH-128288) (cherry picked from commit 0b5f1fa) Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change copies missing
loop_factoryargument description fromasyncio.Runnertoasyncio.rundocstring.The only docstring should be updated, sphinx docs are good already.