Replace deprecated typing imports with collections.abc #18336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
commented
Dec 25, 2024
| @@ -6,7 +6,8 @@ | |||
| import os | |||
| import os.path | |||
| from collections import Counter | |||
| from typing import Any, Dict, Final, Iterable | |||
| from collections.abc import Iterable | |||
| from typing import Any, Dict, Final | |||
There was a problem hiding this comment.
Will replace the generic builtins like Dict, Tuple in a followup.
cdce8p
commented
Dec 25, 2024
| @@ -1,6 +1,7 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| from typing import Callable, Iterable, Sequence | |||
| from collections.abc import Iterable, Sequence | |||
| from typing import Callable | |||
There was a problem hiding this comment.
collections.abc.Callable is broken inside Union and Optional on 3.9.0 and 3.9.1, so it isn't safe to replace just yet. https://bugs.python.org/issue42965
We could consider bumping requires-python to >=3.9.2 or just wait until we drop 3.9 next year.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.