Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stubsabot] Bump croniter to 6.0.0 #13260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

Release: https://pypi.org/pypi/croniter/6.0.0
Homepage: http://github.com/kiorky/croniter
Repository: https://github.com/kiorky/croniter
Typeshed stubs: https://github.com/python/typeshed/tree/main/stubs/croniter
Diff: kiorky/croniter@5.0.1...6.0.0

Stubsabot analysis of the diff between the two releases:

  • Total lines of Python code added: 4188.
  • Total lines of Python code deleted: 709.

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI

Release: https://pypi.org/pypi/croniter/6.0.0
Homepage: http://github.com/kiorky/croniter
Repository: https://github.com/kiorky/croniter
Typeshed stubs: https://github.com/python/typeshed/tree/main/stubs/croniter
Diff: kiorky/croniter@5.0.1...6.0.0

Stubsabot analysis of the diff between the two releases:
 - Total lines of Python code added: 4188.
 - Total lines of Python code deleted: 709.

If stubtest fails for this PR:
- Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
- Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI
@github-actions github-actions bot added the bot: stubsabot 🤖 PRs created by stubsabot 🤖 label Dec 18, 2024
@AlexWaygood AlexWaygood reopened this Dec 18, 2024
@yangdanny97
Copy link
Contributor

yangdanny97 commented Dec 20, 2024

Interesting... the release notes say that this package is unmaintained as of 12/15 and to not rely on it after March 2025: https://pypi.org/project/croniter/6.0.0/

Does that mean we should remove these stubs at that date?

Edit: more discussion here kiorky/croniter#144

@kiorky
Copy link

kiorky commented Dec 20, 2024

Hello, i would suggest you to wait & see the outcome of the linked bug kiorky/croniter#144 (or any further event until the deadline of march).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: stubsabot 🤖 PRs created by stubsabot 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants