Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Ruff FURB #13310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable Ruff FURB #13310

wants to merge 1 commit into from
+2 −1

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Dec 26, 2024

Ref #13295
https://docs.astral.sh/ruff/rules/#refurb-furb

A single autofixable change. Otherwise we already pass all refurb rules.
Although a lot of those rules are still in preview.

JelleZijlstra
JelleZijlstra approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems fine but if more rules make it out of Ruff's preview we'll have to evaluate whether we still want them.

@Avasam
Copy link
Collaborator Author

Avasam commented Dec 28, 2024

There's no harm on waiting on this one for Ruff 0.9 or running it in preview mode to see what it affects.
I vaguely remember there's a rule about preferring Path that is raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avasam @JelleZijlstra