SmallRye GraphQL 2.12.0 and Kotlin 2.1 #45228

jmartisk · 2024-12-20T10:52:46Z

Also replaces #44809

github-actions · 2024-12-20T11:32:09Z

🎊 PR Preview 93eb395 has been successfully built and deployed to https://quarkus-pr-main-45228-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

jmartisk · 2024-12-20T11:32:53Z

Ok it seems this needs a change in the quickstarts: quarkusio/quarkus-quickstarts#1483

geoand · 2024-12-20T12:23:27Z

The gradle test failure seems related:

Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.795 s <<< FAILURE! -- in io.quarkus.gradle.ConditionalDependenciesKotlinTest
Error:  io.quarkus.gradle.ConditionalDependenciesKotlinTest.buildProject -- Time elapsed: 8.787 s <<< FAILURE!
java.lang.AssertionError: Gradle build failed with exit code 1
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:140)
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:57)
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:52)
	at app//io.quarkus.gradle.ConditionalDependenciesKotlinTest.buildProject(ConditionalDependenciesKotlinTest.java:15)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:569)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)

gsmet · 2024-12-20T12:51:26Z

I pushed a small fix for the Gradle failures.

gsmet · 2024-12-20T20:17:53Z

I'm making progress on fixing the issues. I think we might have to upgrade Gradle too.

gsmet · 2024-12-20T20:27:55Z

Even Gradle 8.12 released today isn't compatible with Kotlin 2.1.0: https://docs.gradle.org/current/userguide/compatibility.html#kotlin .

So I suppose this will have to wait.

Failure is:

shouldNotFailOnProjectDependenciesWithoutMain(Path)

org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /tmp/junit16339159363799182023 with arguments [quarkusGenerateCode, --stacktrace]

Output:

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/junit16339159363799182023/mpp/build.gradle.kts' line: 11

* What went wrong:
'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getIsolatedProjects()'

* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

* Exception is:
java.lang.NoSuchMethodError: 'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getIsolatedProjects()'
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76$isProjectIsolationEnabled$2.invoke(ProjectIsolationStartParameterAccessorG76.kt:16)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76$isProjectIsolationEnabled$2.invoke(ProjectIsolationStartParameterAccessorG76.kt:15)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76.isProjectIsolationEnabled(ProjectIsolationStartParameterAccessorG76.kt:15)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorKt.isProjectIsolationEnabled(ProjectIsolationStartParameterAccessor.kt:45)
	at org.jetbrains.kotlin.gradle.plugin.statistics.BuildFusService$Companion.registerIfAbsentImpl(BuildFusService.kt:94)
	at org.jetbrains.kotlin.gradle.plugin.statistics.BuildFusService$Companion.registerIfAbsent(BuildFusService.kt:80)
	at org.jetbrains.kotlin.gradle.plugin.DefaultKotlinBasePlugin.apply(KotlinPluginWrapper.kt:75)
	at org.jetbrains.kotlin.gradle.plugin.KotlinBasePluginWrapper.apply(KotlinPluginWrapper.kt:197)
	at org.jetbrains.kotlin.gradle.plugin.KotlinMultiplatformPluginWrapper.apply(PluginWrappers.kt:74)
	at org.jetbrains.kotlin.gradle.plugin.KotlinMultiplatformPluginWrapper.apply(PluginWrappers.kt:68)
	at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:54)
	at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:51)
	at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:190)

gsmet · 2024-12-20T20:29:31Z

@jmartisk is SmallRye GraphQL 2.12.0 compatible with current main? If so, I think we should probably update in main and keep this PR for the Kotlin update.

I will also create a separate PR for the Gradle update as I think we want it anyway.

quarkus-bot · 2024-12-20T20:58:17Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit cbec954.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2024-12-21T01:51:23Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit cbec954.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 21	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍
✖	Quickstarts Compilation - JDK 17	`Compile Quickstarts`	Failures	Logs	Raw logs	🚧

You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: devtools/gradle/gradle-application-plugin

📦 devtools/gradle/gradle-application-plugin

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.0:exec (gradle) on project io.quarkus.gradle.plugin: Command execution failed.

⚙️ JVM Tests - JDK 21 #

- Failing: devtools/gradle/gradle-application-plugin

📦 devtools/gradle/gradle-application-plugin

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.0:exec (gradle) on project io.quarkus.gradle.plugin: Command execution failed.

⚙️ JVM Tests - JDK 17 Windows #

- Failing: devtools/gradle/gradle-application-plugin

📦 devtools/gradle/gradle-application-plugin

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.0:exec (gradle) on project io.quarkus.gradle.plugin: Command execution failed.

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: hibernate-orm-panache-kotlin-quickstart

📦 hibernate-orm-panache-kotlin-quickstart

✖ Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.9.23:compile (compile) on project hibernate-orm-panache-kotlin-quickstart: Compilation failure

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorTest.testRequestReply - History

iterable contents differ at index [3], expected: <reply-4> but was: <{"details":"Error id a8805af0-442c-4204-b388-1729fbb9c003-1, org.jboss.resteasy.spi.UnhandledException: io.smallrye.mutiny.TimeoutException","stack":"org.jboss.resteasy.spi.UnhandledException: io.smallrye.mutiny.TimeoutException\n\tat org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:107)\n\tat org.jboss.resteasy.core.ExceptionHandler.handleException(ExceptionHandler.java:344)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.writeException(SynchronousDispatcher.java:205)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:452)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.lambda$invokePropagateNotFound$6(SynchronousDispatcher.java:275)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:154)\n\tat org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchC... - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: iterable contents differ at index [3], expected: <reply-4> but was: <{"details":"Error id a8805af0-442c-4204-b388-1729fbb9c003-1, org.jboss.resteasy.spi.UnhandledException: io.smallrye.mutiny.TimeoutException","stack":"org.jboss.resteasy.spi.UnhandledException: io.smallrye.mutiny.TimeoutException\n\tat org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:107)\n\tat org.jboss.resteasy.core.ExceptionHandler.handleException(ExceptionHandler.java:344)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.writeException(SynchronousDispatcher.java:205)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:452)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.lambda$invokePropagateNotFound$6(SynchronousDispatcher.java:275)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:154)\n\tat org.jboss.resteasy.core.interception.jaxrs.PreMatchCon...

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-quickstart

✖ io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled(OpenTelemetryDisabledTest.java:29)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

jmartisk · 2024-12-22T16:46:31Z

Do you know what version of Kotlin we can upgrade to?
SmallRye GraphQL bundles org.jetbrains.kotlin:kotlin-metadata-jvm 2.1.0. It also depends on kotlin compiler 2.1.0 but that is only used in tests, so I think that if Quarkus upgrades to a lower version of Kotlin, it should still work, but we probably do need kotlin-metadata-jvm 2.0+ (1.x definitely won't work because they've changed Java package names)

mschorsch · 2024-12-29T12:08:53Z

Even Gradle 8.12 released today isn't compatible with Kotlin 2.1.0: https://docs.gradle.org/current/userguide/compatibility.html#kotlin .

So I suppose this will have to wait.

Failure is:

shouldNotFailOnProjectDependenciesWithoutMain(Path)

org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /tmp/junit16339159363799182023 with arguments [quarkusGenerateCode, --stacktrace]

Output:

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/junit16339159363799182023/mpp/build.gradle.kts' line: 11

* What went wrong:
'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getIsolatedProjects()'

* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

* Exception is:
java.lang.NoSuchMethodError: 'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getIsolatedProjects()'
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76$isProjectIsolationEnabled$2.invoke(ProjectIsolationStartParameterAccessorG76.kt:16)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76$isProjectIsolationEnabled$2.invoke(ProjectIsolationStartParameterAccessorG76.kt:15)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76.isProjectIsolationEnabled(ProjectIsolationStartParameterAccessorG76.kt:15)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorKt.isProjectIsolationEnabled(ProjectIsolationStartParameterAccessor.kt:45)
	at org.jetbrains.kotlin.gradle.plugin.statistics.BuildFusService$Companion.registerIfAbsentImpl(BuildFusService.kt:94)
	at org.jetbrains.kotlin.gradle.plugin.statistics.BuildFusService$Companion.registerIfAbsent(BuildFusService.kt:80)
	at org.jetbrains.kotlin.gradle.plugin.DefaultKotlinBasePlugin.apply(KotlinPluginWrapper.kt:75)
	at org.jetbrains.kotlin.gradle.plugin.KotlinBasePluginWrapper.apply(KotlinPluginWrapper.kt:197)
	at org.jetbrains.kotlin.gradle.plugin.KotlinMultiplatformPluginWrapper.apply(PluginWrappers.kt:74)
	at org.jetbrains.kotlin.gradle.plugin.KotlinMultiplatformPluginWrapper.apply(PluginWrappers.kt:68)
	at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:54)
	at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:51)
	at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:190)

https://kotlinlang.org/docs/whatsnew21.html#gradle-improvements

Kotlin 2.1.0 is fully compatible with Gradle 7.6.3 through 8.6. Gradle versions 8.7 to 8.10 are also supported
...
You can also use Gradle versions up to the latest Gradle release, but if you do, keep in mind that you might encounter deprecation warnings or some new Gradle features might not work.

gsmet · 2024-12-29T12:12:12Z

Well, we have to figure our why we are getting this error then.

quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/graphql area/smallrye labels Dec 20, 2024

jmartisk mentioned this pull request Dec 20, 2024

Update Kotlin to version 2.1.0 #44809

Closed

jmartisk force-pushed the srgql-2.12.0 branch from e8f0fa5 to fba4cf5 Compare December 20, 2024 10:55

This comment has been minimized.

Sign in to view

jmartisk mentioned this pull request Dec 20, 2024

Upgrade Kotlin to 2.1.0 quarkusio/quarkus-quickstarts#1483

Open

gsmet force-pushed the srgql-2.12.0 branch from fba4cf5 to 6286a11 Compare December 20, 2024 12:51

This comment has been minimized.

Sign in to view

gsmet force-pushed the srgql-2.12.0 branch from 6286a11 to 92425dd Compare December 20, 2024 13:44

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Dec 20, 2024

mskacelik and others added 4 commits December 20, 2024 21:27

SmallRye GraphQL Update to 2.12.0

11268c3

Fixed test where "data":null field is present during an error

74c44d2

Update Kotlin to version 2.1.0

9a36ea6

Update to Gradle 8.12

cbec954

gsmet force-pushed the srgql-2.12.0 branch from 92425dd to cbec954 Compare December 20, 2024 20:27

quarkus-bot bot added area/kotlin area/platform Issues related to definition and interaction with Quarkus Platform labels Dec 20, 2024

gsmet mentioned this pull request Dec 26, 2024

Upcoming Kotlin 2.1.x version looks to be breaking on compiler CLI API #45286

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SmallRye GraphQL 2.12.0 and Kotlin 2.1 #45228

SmallRye GraphQL 2.12.0 and Kotlin 2.1 #45228

jmartisk commented Dec 20, 2024

This comment has been minimized.

github-actions bot commented Dec 20, 2024 •

edited

Loading

jmartisk commented Dec 20, 2024

geoand commented Dec 20, 2024

gsmet commented Dec 20, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gsmet commented Dec 20, 2024

gsmet commented Dec 20, 2024

gsmet commented Dec 20, 2024

quarkus-bot bot commented Dec 20, 2024

quarkus-bot bot commented Dec 21, 2024 •

edited by github-actions bot

Loading

jmartisk commented Dec 22, 2024 •

edited

Loading

mschorsch commented Dec 29, 2024

gsmet commented Dec 29, 2024

SmallRye GraphQL 2.12.0 and Kotlin 2.1 #45228

Are you sure you want to change the base?

SmallRye GraphQL 2.12.0 and Kotlin 2.1 #45228

Conversation

jmartisk commented Dec 20, 2024

This comment has been minimized.

github-actions bot commented Dec 20, 2024 • edited Loading

jmartisk commented Dec 20, 2024

geoand commented Dec 20, 2024

gsmet commented Dec 20, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gsmet commented Dec 20, 2024

gsmet commented Dec 20, 2024

gsmet commented Dec 20, 2024

quarkus-bot bot commented Dec 20, 2024

Status for workflow Quarkus Documentation CI

quarkus-bot bot commented Dec 21, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Failing Jobs

Failures

⚙️ JVM Tests - JDK 17 #

📦 devtools/gradle/gradle-application-plugin

⚙️ JVM Tests - JDK 21 #

📦 devtools/gradle/gradle-application-plugin

⚙️ JVM Tests - JDK 17 Windows #

📦 devtools/gradle/gradle-application-plugin

⚙️ Quickstarts Compilation - JDK 17 #

📦 hibernate-orm-panache-kotlin-quickstart

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-kafka

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-quickstart

jmartisk commented Dec 22, 2024 • edited Loading

mschorsch commented Dec 29, 2024

gsmet commented Dec 29, 2024

github-actions bot commented Dec 20, 2024 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Dec 21, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`

jmartisk commented Dec 22, 2024 •

edited

Loading