Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (ci): adopt astral-sh actions #1014

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnnv1
Copy link

@johnnv1 johnnv1 commented Dec 26, 2024

@johnnv1 johnnv1 marked this pull request as ready for review December 26, 2024 14:08
@johnnv1
Copy link
Author

johnnv1 commented Dec 26, 2024

@adamjstewart i removed the --system from uv pip installs -- this are required for the old versions of UV on gh, i think within their action we didn't need it -- could you reapprove the CI?

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, but would be good to get @qubvel to take a close look too.

I haven't benchmarked these. Is there a noticeable speedup when going from pip to uv in our CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants