Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial suggestions for abstract and intro #49

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LPardue
Copy link
Member

@LPardue LPardue commented Nov 9, 2023

This is intended to be a rewording of the text to align with how other QUIC extensions have come out of the RFC editor.

Also I tried to tighten up the explanation of exactly what range data is reliable.

Copy link
Member

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

Looks like a great improvement.

draft-ietf-quic-reliable-stream-reset.md Outdated Show resolved Hide resolved
@LPardue
Copy link
Member Author

LPardue commented Nov 30, 2023

@kazuho @marten-seemann good to go?

application immediately, without providing any stream data it has received for
that stream.
Version 1 of the QUIC transport protocol ({{!QUIC=RFC9000}}) provides
streams, an ordered and reliable byte stream. Once a sender has started to emit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird mix of singular and plural in this sentence.

application immediately, without providing any stream data it has received for
that stream.
Version 1 of the QUIC transport protocol ({{!QUIC=RFC9000}}) provides
streams, an ordered and reliable byte stream. Once a sender has started to emit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marten-seemann if you are concerned about that, maybe something like:

Suggested change
streams, an ordered and reliable byte stream. Once a sender has started to emit
byte-oriented streams that are ordered and reliable. Once a sender has started to emit

It's almost a duplicate of the first sentence of the abstract, but hopefully nobody cares.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged too quickly. Byte-oriented? I've never heard this term before.
Maybe better: reliable byte-ordered streams.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could go for “byte streams that are ordered and reliable,” if oriented sounds unfamiliar.

Co-authored-by: Kazuho Oku <[email protected]>
@LPardue
Copy link
Member Author

LPardue commented Feb 29, 2024

We can deal with this as part of shepherd writeup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants