Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp3: don't fail on non-ascii lame header version flags #664

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

lazka
Copy link
Member

@lazka lazka commented Nov 25, 2024

See https://issues.oss-fuzz.com/issues/42523736

We could raise there, but we are already returning "?" for unknown flags down below, so just do the same here.

See https://issues.oss-fuzz.com/issues/42523736

We could raise there, but we are already returning "?" for unknown
flags down below, so just do the same here.
@lazka lazka force-pushed the handle-invalid-ascii-lame-version-flag branch from 2bb458f to 3a29f17 Compare November 25, 2024 07:38
Copy link
Collaborator

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree on the (?) solution here.

@lazka lazka merged commit 187b984 into quodlibet:main Nov 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants