Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled graphs] Throw unrecoverable actor exceptions at ray.get() #49461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ruisearch42
Copy link
Contributor

Why are these changes needed?

This PR supports throwing unrecoverable actor exceptions at ray.get(), instead of throwing RayChannelError which was not informative of the actual error. It works by getting and checking the exception from the actor task refs when CompiledDAGRef.get() is about to throw a RayChannelError.

Related issue number

Closes #47790

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core][adag] Throw unrecoverable actor exceptions to top-level ray.get
3 participants