[reefd] Script to launch instance and verify wheels #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
khluu
commented
Nov 19, 2024
khluu
commented
- Launch an EC2 instance with Ubuntu AMI with a bootstrap script that can install conda, clone Ray, and perform wheel verification on Linux x86_64 wheels.
- Store the sanity check results in log then send the log over to the HTTP endpoint to report result.
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
aslonnie
reviewed
Nov 19, 2024
reefd/launch.go
Outdated
| ) | ||
|
|
||
| func main() { | ||
| RAY_VERSION := flag.String("ray_version", "", "The version of Ray to install") |
There was a problem hiding this comment.
nit: don't use app caps, use camel cases.
reefd/launch.go
Outdated
Comment on lines
31
to
52
| mkdir -p ~/miniconda3 | ||
| wget https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh -O ~/miniconda3/miniconda.sh | ||
| bash ~/miniconda3/miniconda.sh -b -u -p ~/miniconda3 | ||
| rm ~/miniconda3/miniconda.sh | ||
| source ~/miniconda3/bin/activate | ||
| git clone https://github.com/ray-project/ray.git | ||
| cd ray | ||
| export RAY_VERSION="%s" | ||
| export RAY_COMMIT="%s" | ||
| export PYTHON_VERSION="%s" | ||
| conda create -n ray python=${PYTHON_VERSION} -y | ||
| conda activate ray | ||
| pip install \ | ||
| --index-url https://test.pypi.org/simple/ \ | ||
| --extra-index-url https://pypi.org/simple \ | ||
| "ray[cpp]==$RAY_VERSION" | ||
|
|
||
| cd release/util | ||
| python sanity_check.py --ray_version="${RAY_VERSION}" --ray_commit="${RAY_COMMIT}" > sanity_check.log | ||
|
|
||
| curl -X POST -d @sanity_check.log "%s" | ||
| `, *RAY_VERSION, *RAY_COMMIT, *PYTHON_VERSION, *ENDPOINT) |
There was a problem hiding this comment.
extract this script out to global scope. in its current form, it is a literal multi-line string, and it is capturing all the \t tab chars.
Signed-off-by: kevin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.