-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: translated home page #909
base: main
Are you sure you want to change the base?
Conversation
@slorber could you check PR? |
I'm not the manager of this repo and don't speak russian, I can't do anything for you sorry 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done!
@titovmx Привет. Можешь чекнуть ПР? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
привет! оставил свои предложения
ещё я думаю, что не нужно пушить файлы idea в репу, так как переводчики могут пользоваться разными инструментами |
@Zukhrik спасибо за перевод! |
@titovmx когда посетил ру.реакт.дев увидел что главная страница не переведена на русский и сразу же начал переводить. После создание ПРа узнаю что надо писать в странице с переводом. Я думал ПР так и будет висеть и ни кто не чекнит. Спасибо за ревью Максим. Скоро апдейтну ПР |
Здравствуйте @titovmx. Можете еще раз чекнуть ПР? |
@Zukhrik спасибо за вклад в перевод и правки! я посмотрю в ближайшие дни |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
спасибо за обновления!
заметил, что несколько проблем осталось
@titovmx Прошу чекнуть ПР еще раз. Спасибо за ревью 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Спасибо за вклад!
LGTM now
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
@titovmx Здравствуйте хотелось узнать когда ПР будет в продакшине. |
Перевод главной страницы