Add Makefile for release #96
Conversation
| from setuptools import setup, find_packages | ||
| from setuptools import find_packages, setup | ||
|
|
||
| from readthedocs_ext import __version__ |
There was a problem hiding this comment.
We're using bump version on the theme and I'd like to start using that on all of our projects. It's a solution that doesn't require importing or reading files to get the version number, and allows us to standardize on setup.cfg as well.
| clean: | ||
| rm -rf dist/ | ||
|
|
||
| .PHONY: release clean tag |
There was a problem hiding this comment.
Seems like a good improvement. I would like to settle on more common tooling patterns across our repos going forward though. On the other repos we're using inv for this, which I quite like. That could maybe be a next step though. I'm generally a fan of make otherwise.
There was a problem hiding this comment.
+1 on standardization. I see that release depends on clean - not sure if invoke supports that sort of dependency tracking though. Brett Cannon asked on Twitter the other day and after a few recommendations, he went for doit https://twitter.com/brettsky/status/1382122878225686529
There was a problem hiding this comment.
Aren't we already using invoke for this? All our .org release tooling is built on it, so we should definitely standardize on that.
There was a problem hiding this comment.
@astrojuanlu yeah, doit helps a lot with cached dependencies too. However, invoke supports pre-tasks http://docs.pyinvoke.org/en/latest/getting-started.html?highlight=pre#declaring-pre-tasks
I'm also 👍🏼 to avoid makefile and use invoke here.
No description provided.