-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure a Deploy command is present in the Devfile before auto-applying components #7093
Merged
openshift-merge-robot
merged 3 commits into
redhat-developer:main
from
rm3l:6743-odo-deploy-auto-started-components-e.g.-with-deploybydefault-true-are-applied-even-if-devfile-has-no-deploy-command
Sep 20, 2023
Merged
Make sure a Deploy command is present in the Devfile before auto-applying components #7093
openshift-merge-robot
merged 3 commits into
redhat-developer:main
from
rm3l:6743-odo-deploy-auto-started-components-e.g.-with-deploybydefault-true-are-applied-even-if-devfile-has-no-deploy-command
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/bug
Categorizes issue or PR as related to a bug.
area/deploy
Issues or PRs specific to the `odo deploy` command
labels
Sep 20, 2023
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
feloy
approved these changes
Sep 20, 2023
openshift-ci
bot
added
the
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
label
Sep 20, 2023
rm3l
deleted the
6743-odo-deploy-auto-started-components-e.g.-with-deploybydefault-true-are-applied-even-if-devfile-has-no-deploy-command
branch
September 20, 2023 12:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/deploy
Issues or PRs specific to the `odo deploy` command
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
/area deploy
What does this PR do / why we need it:
When the Devfile does not have any
deploy
command but contains some components that are auto-applied (e.g., withautoBuild
ordeployByDefault
set totrue
),odo deploy
will try to apply them before ending up complaining that it could not find anydeploy
command.This PR makes sure to check this before applying anything.
See #6743 for more context.
Which issue(s) this PR fixes:
Fixes #6743
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See #6743 for the repro steps.