Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure a Deploy command is present in the Devfile before auto-applying components #7093

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Sep 20, 2023

What type of PR is this:
/kind bug
/area deploy

What does this PR do / why we need it:
When the Devfile does not have any deploy command but contains some components that are auto-applied (e.g., with autoBuild or deployByDefault set to true), odo deploy will try to apply them before ending up complaining that it could not find any deploy command.
This PR makes sure to check this before applying anything.
See #6743 for more context.

Which issue(s) this PR fixes:
Fixes #6743

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
See #6743 for the repro steps.

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/deploy Issues or PRs specific to the `odo deploy` command labels Sep 20, 2023
@openshift-ci openshift-ci bot requested review from feloy and kadel September 20, 2023 10:11
@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit d57d1a1
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/650ad496e14dc30008861c84

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2023

OpenShift Unauthenticated Tests on commit c5462a5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2023

NoCluster Tests on commit c5462a5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2023

Unit Tests on commit c5462a5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2023

Validate Tests on commit c5462a5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2023

Kubernetes Tests on commit c5462a5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2023

Windows Tests (OCP) on commit c5462a5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2023

OpenShift Tests on commit c5462a5 finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2023

Kubernetes Docs Tests on commit 9e1698b finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1ab0178 into redhat-developer:main Sep 20, 2023
@rm3l rm3l deleted the 6743-odo-deploy-auto-started-components-e.g.-with-deploybydefault-true-are-applied-even-if-devfile-has-no-deploy-command branch September 20, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy Issues or PRs specific to the `odo deploy` command kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
3 participants