Fix vercel deployment #27
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/platforme/ripe-sdk-components-react/g5xuuyrpd |
BeeMargarida
changed the title
package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "scripts": { | |||
| "build": "cross-env NODE_ENV=production webpack --mode production --config webpack.config.js", | |||
| "build-dev": "cross-env NODE_ENV=development webpack --mode development --config webpack.config.js", | |||
| "build-storybook": "cross-env NODE_ENV=development build-storybook -c .storybook -o dist/storybook", | |||
| "build-storybook": "build-storybook -c .storybook -o dist/storybook", | |||
There was a problem hiding this comment.
What's wrong with the cross-env part?
package.json
Outdated
| @@ -48,8 +48,8 @@ | |||
| "loaders.css": "^0.1.2", | |||
| "mocha": "^8.2.1", | |||
| "prop-types": "^15.7.2", | |||
| "react": "^17.0.1", | |||
| "react-dom": "^17.0.1", | |||
| "react": "<17.0.0", | |||
There was a problem hiding this comment.
Try to find the semver expression that gives you the latest version inside 16. The difference between this and that is that 10.0.0 would be a valid version given your expression.
There was a problem hiding this comment.
Done, used this https://semver.npmjs.com/
Used for testing of the react components |
Oh we are using it directly, alright. |
|
@gcandal The links to subscribe to: |
@babel/plugin-transform-runtime, which was being used but was not a dependency.- There seems to be a problem between webpack 5 and storybook (here and here), with storybook still not supporting webpack@5. Since webpack is a dependency of this repo, it causes a certain number of problems in the deployment and usage. The solution was forcing the webpack version to below 5.
- The option
--no-dllwas included because storybook needs this for now (storybookjs/storybook#12408). Since the react version is limited because of enzyme and its support for react 17, I removed it.- Enzyme is not yet compatible with react 17 (enzymejs/enzyme#2462), so the react version was forced to be below 17.