Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic DVP support #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add basic DVP support #13

wants to merge 4 commits into from

Conversation

Winnaries
Copy link

@Winnaries Winnaries commented Feb 19, 2021 •
edited
Loading

Changes Made

  • Implemented a APB1 and APB2 clock controls
  • Added APB1 and APB2 field to Clocks struct
  • Added basic SCCB operation eg. send/receive data
  • Added image control function of DVP (referring to C library)

Purpose

  • I was going to use this crate for interfacing my board with OV2640 using DVP, therefore this PR.

Readiness

  • Not going to put any further commit to this PR, therefore it is ready to merge after it has been officially reviewed and accepted.

I appreciate any feedbacks 👀

@Winnaries Winnaries marked this pull request as ready for review February 20, 2021 04:51
longfangsong
longfangsong reviewed Feb 20, 2021
View reviewed changes
src/dvp.rs
}

pub fn init(&self) {
// Consider borrowing i.s.o. using global instance of sysctl?
Copy link
Contributor

@longfangsong longfangsong Feb 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Unofficial opinion)
I prefer this idea, IMO all clk related things should be in sysctl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longfangsong longfangsong longfangsong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Winnaries @longfangsong