Add SquiggleCop to baseline analyzer settings #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmurillo
added
dependencies
MattKotsenas
force-pushed
the
feature/squigglecop
branch
from
822ddef to
4a822ad
Compare
rjmurillo
previously approved these changes
Jul 29, 2024
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
MattKotsenas
force-pushed
the
feature/squigglecop
branch
from
d355349 to
e4e0499
Compare
MattKotsenas
force-pushed
the
feature/squigglecop
branch
from
f6729cd to
79a46ea
Compare
MattKotsenas
force-pushed
the
feature/squigglecop
branch
from
56cc8b7 to
bf5bcdf
Compare
MattKotsenas
force-pushed
the
feature/squigglecop
branch
from
bf5bcdf to
5889489
Compare
rjmurillo
reviewed
Aug 1, 2024
Yes, once that one merges I'll rebase away the changes here and merge. |
MattKotsenas
added a commit
that referenced
this pull request
Aug 1, 2024
Update .NET SDK to the latest released version and disable `rollForward`. Updates to the .NET SDK feature band can introduce new / updated analyzers (for instance, 8.0.400 adds [IDE0320](dotnet/roslyn#73012)). As a result, updating the feature band isn't "safe" to do from a build reproducibility perspective. It will also conflict with #166. That means the roll forward options available to us are: - `patch` - `latestPatch` - `disable` However, GitHub Actions don't support these options (tracked by actions/setup-dotnet#448). Thus, the only `rollForward` strategy that currently does the same thing locally and in CI is `disabled`. Once 448 is fixed, we can / should probably switch to `latestPatch` (tracked by #171). This 'gotcha' is also added to the SquiggleCop documentation [here](https://github.com/MattKotsenas/SquiggleCop?tab=readme-ov-file#common-sources-of-baseline-mismatches).
Update SquiggleCop version
MattKotsenas
force-pushed
the
feature/squigglecop
branch
from
5889489 to
c049e09
Compare
|
Code Climate has analyzed commit c049e09 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SquiggleCop to baseline the analyzers and their configuration. This intends to prevent accidental changes / regressions to the project, such as #165.
Changes made
SquiggleCop.Tasksand wire into the existing$(PedanticMode)to validate baselinesSquiggleCop.Toolto support ad-hoc baselining / troubleshootingCONTRIBUTING.mdwith re-baselining procedureglobal.jsonto latest version and disable rollforward to support reproducible build