Allow non-gurobi solvers #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoOkuma
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Hi @MikeLippincott thanks for the contribution,
Sorry for the bunch of suggestions.
I started with only one, but then I realized we were passing the whole tracking_config and the solver_name separately, which is redudant.
I think you could just change the MIPSolver class to use the solver_name when creating the mip.Model, this part of the code,
Let me know if you're busy and I can finish this PR.
Co-authored-by: Jordão Bragantini <[email protected]>
Co-authored-by: Jordão Bragantini <[email protected]>
Co-authored-by: Jordão Bragantini <[email protected]>
Co-authored-by: Jordão Bragantini <[email protected]>
|
Thank you for the review @JoOkuma. I really overthought this one. I appreciate the changes. I tested in my local env and ultrack works without gurobi installed. Requesting re-review. Please feel free to take over from here if easier! Thank you for the response and development for this package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not have gurobi installed as we have some commerical collaborations that would violate the use of the free version.
Instead, I wish to use the CBC solver.
This PR is in response to issue 173