Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect: add support for RHEL distributions to startup script #502

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Connect: add support for RHEL distributions to startup script #502

wants to merge 3 commits into from

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented May 10, 2024

Same as #453

@dbkegley
Copy link
Contributor

Looks good! This will need a chart version bump and then I think it's good to merge

@pat-s
Copy link
Contributor Author

pat-s commented Dec 20, 2024

@dbkegley Should be good to go.

Somewhat confusing that CI for forked PRs always fails due to missing write permissions on the fork by the CI bot.

@dbkegley
Copy link
Contributor

@jforest How should we address contributions from forks for this repo given that CI doesn't run? I can't override these merges anymore since the permissions have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aronatkins aronatkins Awaiting requested review from aronatkins aronatkins is a code owner

@dbkegley dbkegley Awaiting requested review from dbkegley dbkegley is a code owner

@christierney christierney Awaiting requested review from christierney christierney is a code owner

@zackverham zackverham Awaiting requested review from zackverham zackverham is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pat-s @dbkegley