Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rails test:all #5338

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kuanchiliao1
Copy link
Contributor

@Kuanchiliao1 Kuanchiliao1 commented Dec 17, 2024

There is also a ProfileTest class in test/system and I was getting an error, so went ahead and made this class name more specific.

This is the error
image

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (96cba03) to head (9596ab4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5338      +/-   ##
==========================================
- Coverage   97.14%   94.37%   -2.77%     
==========================================
  Files         458      458              
  Lines        9584     9643      +59     
==========================================
- Hits         9310     9101     -209     
- Misses        274      542     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colby-swandale
Copy link
Member

Looking at both the Integration and the System ProfileTest side by side, they are basically the same in nature, so I would like to make this simpler by merging the Integration ProfileTest into the System ProfileTest

@Kuanchiliao1
Copy link
Contributor Author

Should be all merged into System ProfileTest now - kept existing tests intact with minimal changes just to make it compatible with Selenium

@Kuanchiliao1 Kuanchiliao1 force-pushed the fix-rails-test-all branch 2 times, most recently from 4d6699d to 3fa7b3d Compare December 23, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants