Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try again to use Podman instead of Docker #1392

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Try again to use Podman instead of Docker #1392

merged 1 commit into from
Dec 27, 2024

Conversation

chinrw
Copy link
Contributor

@chinrw chinrw commented Dec 27, 2024

Switch from Docker to Podman for container builds and remove unused buildx steps.

Also this commit updates GitHub Actions workflows to use redhat-actions/podman-login and docker/setup-qemu-action@v3, removing references to Docker Buildx.

Fixes: ec1d712 ("Use docker only on GitHub Actions")

@chinrw
Copy link
Contributor Author

chinrw commented Dec 27, 2024

Build all tarballs passed: https://github.com/chinrw/mold/actions/runs/12512234008

Switch from Docker to Podman for container builds and remove unused
buildx steps. Also this commit updates GitHub Actions workflows to use
redhat-actions/podman-login and docker/setup-qemu-action@v3, removing
references to Docker Buildx.

Fixes: ec1d712 ("Use docker only on GitHub Actions")
Signed-off-by: Ruowen Qin <[email protected]>
@rui314 rui314 merged commit b8fa19b into rui314:main Dec 27, 2024
14 checks passed
@rui314
Copy link
Owner

rui314 commented Dec 27, 2024

Ah, nice. It's easier than I thought. Thanks!

@rui314
Copy link
Owner

rui314 commented Dec 27, 2024

It looks like it was failing: https://github.com/rui314/mold/actions/runs/12514398299/job/34910406472

Can you take a look?

@chinrw
Copy link
Contributor Author

chinrw commented Dec 27, 2024

It looks like it was failing: https://github.com/rui314/mold/actions/runs/12514398299/job/34910406472

Can you take a look?

looks wired will figure it out later

@rui314
Copy link
Owner

rui314 commented Dec 27, 2024

e56fc35 may have fixed the issue

@chinrw
Copy link
Contributor Author

chinrw commented Dec 27, 2024

e56fc35 may have fixed the issue

That could be the reason, since my github CI runner is ubuntu-24.04 link and the failed github action is running on 22.04.5. Not sure why the ubuntu-latest will use the LTS.

@jinghao-jia
Copy link
Contributor

jinghao-jia commented Dec 27, 2024

e56fc35 may have fixed the issue

That could be the reason, since my github CI runner is ubuntu-24.04 link and the failed github action is running on 22.04.5. Not sure why the ubuntu-latest will use the LTS.

This is probably the reason: actions/runner-images#10636

Breaking changes

Ubuntu 24.04 is ready to be the default version for the "ubuntu-latest" label in GitHub Actions and Azure DevOps.

Target date

This change will be rolled out over a period of several weeks beginning December 5th and will complete on January 17th, 2025.

My guess is the mold repo has not received the change yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants