Consider empty-unreachable otherwise branches in MatchBranchSimplification #131244

clubby789 · 2024-10-04T15:12:09Z

rustbot · 2024-10-04T15:12:17Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-10-04T15:12:19Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

jieyouxu · 2024-10-04T15:13:54Z

r? wg-mir-opt

clubby789 · 2024-10-04T19:34:59Z

~~Hmm, while I think this change is useful (given the improvement in another test), while checking the diffs I noticed that (on current master) the motivating example emits~~

fn my_is_some(_1: &Option<T>) -> bool {
    debug bar => _1;
    let mut _0: bool;
    let mut _2: isize;

    bb0: {
        _2 = discriminant((*_1));
        switchInt(move _2) -> [1: bb2, otherwise: bb1];   // two-branch SwitchInt, not 3
    }

    bb1: {
        _0 = const false;
        goto -> bb3;
    }

    bb2: {
        _0 = const true;
        goto -> bb3;
    }

    bb3: {
        return;
    }
}

~~And is therefore simplified by MatchBranchSimplification to the Eq version~~
Ah I see. At normal opt-levels, UnreachableEnumBranching adds the unreachable branch which inhibits this opt. Presumably the test runs with no other opts enabled, so the two-branch switch is simplified to an Eq

tests/mir-opt/matches_reduce_branches.my_is_some.MatchBranchSimplification.diff

clubby789 · 2024-10-27T14:23:18Z

@bors try @rust-timer queue

…, r=<try> Consider empty-unreachable otherwise branches in MatchBranchSimplification Fixes rust-lang#131219

bors · 2024-10-27T14:24:29Z

⌛ Trying commit 7cd33b8 with merge 20e541a...

bors · 2024-10-27T16:18:18Z

☀️ Try build successful - checks-actions
Build commit: 20e541a (20e541ae5fc472867330cb73999e8ec1ffcb7b83)

rust-timer · 2024-10-27T18:00:11Z

Finished benchmarking commit (20e541a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.0%]	2
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-0.1%	[-0.8%, 0.3%]	4

Max RSS (memory usage)

Results (primary 4.7%, secondary -3.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.7%	[2.1%, 8.9%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	4.7%	[2.1%, 8.9%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary -0.0%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 1.0%]	11
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.6%, -0.0%]	31
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.0%]	5
All ❌✅ (primary)	-0.0%	[-0.6%, 1.0%]	42

Bootstrap: 783.769s -> 780.785s (-0.38%)
Artifact size: 333.67 MiB -> 333.62 MiB (-0.02%)

…, r=DianQK Consider empty-unreachable otherwise branches in MatchBranchSimplification Fixes rust-lang#131219

rust-log-analyzer · 2024-12-27T16:49:08Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2024-12-27T16:39:28Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-27T16:39:28Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-27T16:39:28Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpXVMBHX#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-27T16:39:30Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-12-27T16:39:30Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpXVMBHX#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpXVMBHX\\incremental-state"
[2024-12-27T16:39:32Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-12-27T16:39:32Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpXVMBHX#[email protected]" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpXVMBHX\\incremental-state"
[2024-12-27T16:39:32Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-27T16:39:32Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-27T16:39:33Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpYgdzAG#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-27T16:39:34Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 5.093
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\symbols.o" "<1 object files omitted>" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_driver-a0ac91cb0b8079ab.dll.lib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib/{libcompiler_builtins-c25bba97e86b102c.rlib}" "psapi.lib" "shell32.lib" "ole32.lib" "uuid.lib" "advapi32.lib" "ws2_32.lib" "ntdll.lib" "kernel32.lib" "advapi32.lib" "ole32.lib" "oleaut32.lib" "advapi32.lib" "cfgmgr32.lib" "gdi32.lib" "kernel32.lib" "msimg32.lib" "opengl32.lib" "user32.lib" "winspool.lib" "bcrypt.lib" "advapi32.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:libcmt" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcNNRYQP\\wofutil.dll_imports_indirect.lib" "/NXCOMPAT" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\stacker-813e2ed640f28cfe\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\psm-4c4664380d8877b3\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-035b9bcae595ec99\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-035b9bcae595ec99\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\rustc_llvm-30f90b3e1aaa039f\\out" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\llvm\\lib" "/OUT:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_main-03a98b8d95adfc8a.exe" "/OPT:REF,ICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/MANIFEST:EMBED" "/MANIFESTINPUT:C:\\a\\rust\\rust\\compiler\\rustc\\Windows Manifest.xml" "/WX"
  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_main-03a98b8d95adfc8a.exe'␍
          

[RUSTC-TIMING] rustc_main test:false 0.681

bors · 2024-12-27T16:49:47Z

💔 Test failed - checks-actions

clubby789 · 2024-12-27T16:52:44Z

  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_main-03a98b8d95adfc8a.exe'␍

@bors retry

…, r=DianQK Consider empty-unreachable otherwise branches in MatchBranchSimplification Fixes rust-lang#131219

bors · 2024-12-27T22:08:04Z

⌛ Testing commit e32ec45 with merge 1b2e1fd...

rust-log-analyzer · 2024-12-27T23:20:24Z

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests\ui\runtime\backtrace-debuginfo.rs stdout ----

error: test run failed!
status: exit code: 101
command: PATH="C:\a\rust\rust\build\i686-pc-windows-gnu\stage2\lib\rustlib\i686-pc-windows-gnu\lib;C:\a\rust\rust\build\i686-pc-windows-gnu\stage0-bootstrap-tools\i686-pc-windows-gnu\release\deps;C:\a\rust\rust\build\i686-pc-windows-gnu\stage0\bin;C:\a\_temp\msys64\mingw32\bin;C:\a\_temp\msys64\usr\local\bin;C:\a\_temp\msys64\usr\bin;C:\a\_temp\msys64\usr\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\mingw32\bin;C:\a\rust\rust\sccache;C:\a\_temp\setup-msys2;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.1.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.432-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\a\_temp\msys64\usr\bin\site_perl;C:\a\_temp\msys64\usr\bin\vendor_perl;C:\a\_temp\msys64\usr\bin\core_perl" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\test\\ui\\runtime\\backtrace-debuginfo\\a.exe"
---------------------------------------
trace does not match position list
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184", "backtrace-debuginfo.rs:121", "backtrace-debuginfo.rs:109", "backtrace-debuginfo-aux.rs:13"]
--- stdout
backtrace-debuginfo-aux.rs:13
backtrace-debuginfo.rs:109
backtrace-debuginfo.rs:121
---
explicit panic
stack backtrace:
   0: 0x74a05ecd - core::fmt::write::h878e7131013905a3
   1: 0x749a2794 - std::io::Write::write_fmt::h527eba61bc0634ec
   2:   0xcaadc0 - <unknown>
   3: 0x749b0402 - std::panicking::payload_as_str::he2dc250d0451a655
   4: 0x749af9f8 - std::panicking::default_hook::h233f8e63499f6eb0
   5: 0x749af2c4 - ___rdl_alloc
   6: 0x749cf2f2 - std::panicking::panic_count::LOCAL_PANIC_COUNT::{{closure}}::h0fac959501ff8818
   7: 0x749b0564 - std::panicking::rust_panic_with_hook::hcd729b152a3d1195
   8: 0x749ad9db - std::sys::backtrace::__rust_end_short_backtrace::hbf3d6af0a250aaf6
   9: 0x749b0284 - std::panicking::begin_panic::h168adde970dabe2b
  10:   0xcaadb0 - <unknown>
  11:   0xcaadb0 - <unknown>
  12: 0x771150b6 - <unknown>
  13: 0x749935bf - std::thread::current::set_current::ha8360da5b2a5d859
  14: 0x749930c5 - std::rt::lang_start_internal::h8799bd1d3f51426f
  15:   0x85284b - std::rt::lang_start::had8a51d2557ce90a
                       at /rustc/FAKE_PREFIX\library\std\src/rt.rs:194:17
  16:   0x85f0fe - _main
  17:   0x8512f0 - ___tmainCRTStartup
  18: 0x76b267f9 - <unknown>
  19: 0x77e47f6d - <unknown>
  20: 0x77e47f3b - <unknown>
--- stderr -------------------------------
thread 'main' panicked at C:\a\rust\rust\tests\ui\runtime\backtrace-debuginfo.rs:174:9:
found some errors
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---
test result: FAILED. 17799 passed; 1 failed; 360 ignored; 0 measured; 23 filtered out; finished in 880.22s

Some tests failed in compiletest suite=ui mode=ui host=i686-pc-windows-gnu target=i686-pc-windows-gnu
Build completed unsuccessfully in 1:00:20
make: *** [Makefile:115: ci-mingw-x] Error 1
  network time: Fri, 27 Dec 2024 23:20:07 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2024-12-27T23:21:01Z

💔 Test failed - checks-actions

clubby789 · 2024-12-27T23:28:42Z

Hmm. This doesn't look related, but can't imagine what could cause it?

clubby789 · 2024-12-28T01:20:12Z

@bors retry
#117097

…eemdev Disable `backtrace-debuginfo.rs` on windows-gnu This test appears still flaky cf. rust-lang#117097 on `i686-mingw` as observed in rust-lang#131244 (comment). r? compiler (or anyone, really)

bors · 2024-12-28T11:09:31Z

⌛ Testing commit e32ec45 with merge 4e0bc49...

bors · 2024-12-28T13:48:36Z

☀️ Test successful - checks-actions
Approved by: DianQK
Pushing 4e0bc49 to master...

rust-timer · 2024-12-28T15:04:21Z

Finished benchmarking commit (4e0bc49): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.3%	[0.2%, 0.3%]	4
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	2
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	2
All ❌✅ (primary)	-0.3%	[-0.7%, 0.2%]	3

Max RSS (memory usage)

Results (primary 0.3%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[1.3%, 5.6%]	6
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-2.9%	[-4.3%, -2.1%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-4.3%, 5.6%]	12

Cycles

Results (secondary 5.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.5%	[4.6%, 8.7%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-1.9%, -1.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.4%]	15
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-1.1%, -0.0%]	20
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	5
All ❌✅ (primary)	-0.0%	[-1.1%, 0.4%]	35

Bootstrap: 761.626s -> 763.637s (0.26%)
Artifact size: 325.64 MiB -> 325.42 MiB (-0.07%)

…, r=DianQK Consider empty-unreachable otherwise branches in MatchBranchSimplification Fixes rust-lang#131219

…eemdev Disable `backtrace-debuginfo.rs` on windows-gnu This test appears still flaky cf. rust-lang#117097 on `i686-mingw` as observed in rust-lang#131244 (comment). r? compiler (or anyone, really)

rustbot assigned jieyouxu Oct 4, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 4, 2024

clubby789 changed the title ~~Add diff test for MatchBranchSimplification~~ Consider empty-unreachable otherwise branches in MatchBranchSimplification Oct 4, 2024

rust-cloud-vms bot force-pushed the match-branches-unreachable branch from e7e8678 to 67c9f97 Compare October 4, 2024 15:13

rustbot assigned wesleywiser and unassigned jieyouxu Oct 4, 2024

rust-cloud-vms bot force-pushed the match-branches-unreachable branch 3 times, most recently from e6f54ee to ba723e6 Compare October 4, 2024 20:34

clubby789 commented Oct 4, 2024

View reviewed changes

tests/mir-opt/matches_reduce_branches.my_is_some.MatchBranchSimplification.diff Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the match-branches-unreachable branch from ba723e6 to 66edf31 Compare October 4, 2024 23:04

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the match-branches-unreachable branch from 66edf31 to c0d609d Compare October 5, 2024 08:36

rust-cloud-vms bot force-pushed the match-branches-unreachable branch from c0d609d to 7cd33b8 Compare October 27, 2024 14:21

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 27, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024

Auto merge of rust-lang#131244 - clubby789:match-branches-unreachable…

20e541a

…, r=<try> Consider empty-unreachable otherwise branches in MatchBranchSimplification Fixes rust-lang#131219

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 27, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2024

Auto merge of rust-lang#131244 - clubby789:match-branches-unreachable…

69da6c3

…, r=DianQK Consider empty-unreachable otherwise branches in MatchBranchSimplification Fixes rust-lang#131219

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2024

clubby789 added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Dec 27, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2024

Auto merge of rust-lang#131244 - clubby789:match-branches-unreachable…

1b2e1fd

…, r=DianQK Consider empty-unreachable otherwise branches in MatchBranchSimplification Fixes rust-lang#131219

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2024

clubby789 mentioned this pull request Dec 28, 2024

test ui/backtrace-debuginfo.rs is flaky #117097

Open

jieyouxu mentioned this pull request Dec 28, 2024

Disable backtrace-debuginfo.rs on windows-gnu #134842

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 28, 2024

bors merged commit 4e0bc49 into rust-lang:master Dec 28, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 28, 2024

poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request Dec 28, 2024

Auto merge of rust-lang#131244 - clubby789:match-branches-unreachable…

02e12b1

…, r=DianQK Consider empty-unreachable otherwise branches in MatchBranchSimplification Fixes rust-lang#131219

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consider empty-unreachable otherwise branches in MatchBranchSimplification #131244

Consider empty-unreachable otherwise branches in MatchBranchSimplification #131244

clubby789 commented Oct 4, 2024 •

edited

Loading

rustbot commented Oct 4, 2024

rustbot commented Oct 4, 2024

jieyouxu commented Oct 4, 2024

clubby789 commented Oct 4, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

clubby789 commented Oct 27, 2024

This comment has been minimized.

bors commented Oct 27, 2024

bors commented Oct 27, 2024

This comment has been minimized.

rust-timer commented Oct 27, 2024

rust-log-analyzer commented Dec 27, 2024

bors commented Dec 27, 2024

clubby789 commented Dec 27, 2024

bors commented Dec 27, 2024

rust-log-analyzer commented Dec 27, 2024

bors commented Dec 27, 2024

clubby789 commented Dec 27, 2024

clubby789 commented Dec 28, 2024

bors commented Dec 28, 2024

bors commented Dec 28, 2024

rust-timer commented Dec 28, 2024

Consider empty-unreachable otherwise branches in MatchBranchSimplification #131244

Consider empty-unreachable otherwise branches in MatchBranchSimplification #131244

Conversation

clubby789 commented Oct 4, 2024 • edited Loading

rustbot commented Oct 4, 2024

rustbot commented Oct 4, 2024

jieyouxu commented Oct 4, 2024

clubby789 commented Oct 4, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

clubby789 commented Oct 27, 2024

This comment has been minimized.

bors commented Oct 27, 2024

bors commented Oct 27, 2024

This comment has been minimized.

rust-timer commented Oct 27, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

rust-log-analyzer commented Dec 27, 2024

bors commented Dec 27, 2024

clubby789 commented Dec 27, 2024

bors commented Dec 27, 2024

rust-log-analyzer commented Dec 27, 2024

bors commented Dec 27, 2024

clubby789 commented Dec 27, 2024

clubby789 commented Dec 28, 2024

bors commented Dec 28, 2024

bors commented Dec 28, 2024

rust-timer commented Dec 28, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

clubby789 commented Oct 4, 2024 •

edited

Loading

clubby789 commented Oct 4, 2024 •

edited

Loading