-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gagnon_Tahiri : New updates #1042
Conversation
Correct Water mass order
Adjustment F4 and F5
Text metrics adjustment
Removing Fig2
Fig2 adjustment
Corrections
Corrections
Removing fig3
Adjustment
Removing key word
Adjustment
Corrections abstract
Correction title
Adjustment
Delete Table Genetic
Adjustment
Corrections Table 1
Corrections
Correction
Correction
Adjustment preprocessing
Adjustments
Adjustments
Adjustments
Corrections
Fig 2
New source fig 2
Update fig 1
Update fig 1
Adjustments
Correction Field ID
Correction citation
Adjustment citation
Correction space
Adjustment
Adjustment nt
Correction code and names
Adjustment
Corrections text
Corrections
Corrections salinity
Hi @JustGag - In addition to the merge conflicts in this pull request, there are 30 commits, figure changes, and very large text changes. Your comment says minor text updates, so I am guessing that something has gone wrong or this is out of date? I am going to close this pull request. If there are critical changes that you feel are absolutely necessary for your paper, now that it has been published, please make a small, targeted commit with only those changes. |
Hi Mr Cockett,
We hope you're well. Although the number of commit is large, the essential content of the article remains unchanged and nothing has gone wrong or is out of date. As far as the figures are concerned, we have reduced the outline size of all the images included.
We thank you for your understanding and will take your suggestions into careful consideration.
Sincerely,
Justin Gagnon
…________________________________
De : Rowan Cockett ***@***.***>
Envoyé : 15 novembre 2024 22:27
À : scipy-conference/scipy_proceedings ***@***.***>
Cc : Justin Gagnon ***@***.***>; Mention ***@***.***>
Objet : Re: [scipy-conference/scipy_proceedings] Gagnon_Tahiri : New updates (PR #1042)
Hi @JustGag<https://github.com/JustGag> - In addition to the merge conflicts in this pull request, there are 30 commits, figure changes, and very large text changes. Your comment says minor text updates, so I am guessing that something has gone wrong or this is out of date? I am going to close this pull request.
If there are critical changes that you feel are absolutely necessary for your paper, now that it has been published, please make a small, targeted commit with only those changes.
—
Reply to this email directly, view it on GitHub<#1042 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BFW5PNNZEMOWDJPZXVR67732A23T7AVCNFSM6AAAAABRP2KM6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGM3DSNJQGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
If you are creating this PR in order to submit a draft of your paper, please name your PR with
Paper: <title>
. An editor will then add apaper
label and GitHub Actions will be run to check and build your paper.See the project readme for more information.
Editor:
Reviewers:
Minor text updates + Fixing figures