[WIP]: Dockerizing Nymeria #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackbird7112
requested changes
Sep 10, 2022
adrijshikhar
requested changes
Sep 13, 2022
docker-compose.yaml
Outdated
| context: ./ | ||
| dockerfile: Dockerfile | ||
| extra_hosts: | ||
| - "localhost:127.0.0.1" |
There was a problem hiding this comment.
why are you doing this?
There was a problem hiding this comment.
i read the documentation for docker-compose files, i came across this argument, it's basically used to add customised hosts to the container. I now realise that this isn't needed, so i have removed it.
docker-compose.yaml
Outdated
| ports: | ||
| - '5432:5432' | ||
| volumes: | ||
| - ./pgdata:/var/lib/postgresql/data/pgdata |
There was a problem hiding this comment.
do not use bind volumes, use named volumes for reliability
pratham1729
force-pushed
the
dockerize
branch
from
5c6240a to
743e30d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.