Fix PHPStan level 7 errors #6084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Dec 14, 2024
| @@ -72,7 +72,7 @@ public function requirementsNotSatisfiedFor(string $className, string $methodNam | |||
|
|
|||
| if (!extension_loaded($metadata->extension()) || | |||
| ($metadata->hasVersionRequirement() && | |||
| !$metadata->versionRequirement()->isSatisfiedBy(phpversion($metadata->extension())))) { | |||
| !$metadata->versionRequirement()->isSatisfiedBy(phpversion($metadata->extension()) ?: ''))) { | |||
There was a problem hiding this comment.
extensions might not provide version info and this line can return false
staabm
force-pushed
the
fix
branch
2 times, most recently
from
6024a62 to
9e96bff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6084 +/- ##
=========================================
Coverage 94.64% 94.64%
- Complexity 6645 6649 +4
=========================================
Files 713 713
Lines 20911 20911
=========================================
Hits 19791 19791
Misses 1120 1120 ☔ View full report in Codecov by Sentry. |
staabm
commented
Dec 14, 2024
src/Metadata/Version/Requirement.php
Outdated
| @@ -23,7 +23,7 @@ | |||
| */ | |||
| abstract readonly class Requirement | |||
| { | |||
| private const VERSION_COMPARISON = '/(?P<operator>[<>=!]{0,2})\s*(?P<version>[\d\.-]+(dev|(RC|alpha|beta)[\d\.])?)[ \t]*\r?$/m'; | |||
| private const VERSION_COMPARISON = "/(?P<operator>!=|<|<=|<>|=|==|>|>=)?\s*(?P<version>[\d\.-]+(dev|(RC|alpha|beta)[\d\.])?)[ \t]*\r?$/m"; | |||
There was a problem hiding this comment.
operators copied from ComparisonRequirement constructor
staabm
commented
Dec 14, 2024
| @@ -89,7 +89,7 @@ final class Generator | |||
| * | |||
| * @param class-string $type | |||
| * @param ?list<non-empty-string> $methods | |||
| * @param list<mixed> $arguments | |||
| * @param array<mixed> $arguments | |||
There was a problem hiding this comment.
Named args cannot be a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing low hanging fruits. not all errors are resolved yet
Some more are fixed with phpstan/phpstan-src#3731