Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update active tab if the "active" property on a sl-tab changes #2299

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update active tab if the "active" property on a sl-tab changes #2299

merged 1 commit into from
Dec 4, 2024

Conversation

kirchsuSICKAG
Copy link
Contributor

Closes #2298

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shoelace ✅ Ready (Inspect) Visit Preview Dec 4, 2024 3:35pm

@kirchsuSICKAG kirchsuSICKAG mentioned this pull request Dec 4, 2024
Closed
6 tasks
claviska
claviska approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@claviska claviska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement and it works well. Thanks!

@claviska claviska merged commit 5267aa9 into shoelace-style:next Dec 4, 2024
1 of 2 checks passed
@mathijssterk mathijssterk mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claviska claviska claviska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing active sl-tab via "active" property is not working
2 participants
@kirchsuSICKAG @claviska