Use new mochify, update dependencies, drop old node #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Caveat
I could not use ESBuild as the mochify bundler because it ran into a dual package hazard issue with
sinon
.browser
field inpackage.json
and decides to load./lib/sinon.js
.exports
and chooses thebrowser
field from there, which points to./pkg/sinon-esm.js
.I can override that behaviour with
conditions
, but then ESBuild complains that it cannot resolveassert
, while Browserify will happily shim that dependency transparently.Update: Consuming this with ESBuild doesn't work due to sinonjs/sinon#2519. Reverting this change makes it work again. ¯\(ツ)/¯
How to verify - mandatory
npm install
npm run lint
npm test
npm run test-cloud
Checklist for author
npm run lint
passes