slack-19.0: use slackhq/[email protected]
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
ejortegau
previously approved these changes
Dec 18, 2024
Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt
commented
Dec 18, 2024
|
|
||
| // TODO: remove this conditional and 'else' side after vtops-vtorc is used 100%. | ||
| if strings.HasSuffix(vtopsPath, "vtops-vtorc") { | ||
| vtopsExec.RaiseProblem(analysisEntry.AnalyzedInstanceAlias, "orc-dead-tablet") |
There was a problem hiding this comment.
I made vtops-vtorc avoid some extra calls by passing an alias instead of hostname. This means we need this conditional during the rollout
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt
changed the title
slack-19.0: use slackhq/[email protected]slack-19.0: use slackhq/[email protected]
timvaillancourt
commented
Dec 18, 2024
go.mod
Outdated
| @@ -101,7 +101,7 @@ require ( | |||
| github.com/kr/text v0.2.0 | |||
| github.com/mitchellh/mapstructure v1.5.0 | |||
| github.com/nsf/jsondiff v0.0.0-20210926074059-1e845ec5d249 | |||
| github.com/slackhq/vitess-addons v0.19.4 | |||
| github.com/slackhq/vitess-addons v0.19.6-0.20241218193729-2cb0c6fc208a | |||
There was a problem hiding this comment.
TODO: cut a real tag before this is merged. This is a pinned commit
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
slackhq/vitess-addonstotheTODO: cutv0.19.5tagv0.19.6tag - currently using a pinned commitAlso the source-name for vtops problems was simplified to be
vtorc-POOL-ENVvs. the longer/redundantvtorc-bedrock-POOL-ENVand a conditional to pass tablet alias tovtops-vtorcwas addedRelated Issue(s)
Checklist
Deployment Notes