-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Option for viewing sr decks and cards in tabs #1169
Conversation
…eopen of obsidian
…produced an error
…ting and by refactoring functionality into extra files
Please dont merge it just yet; I have discovered, that the button alignment breaks, if one tilts the phone into horizontal mode 😅 |
… not in focus & some formatting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
+ Coverage 92.91% 92.97% +0.05%
==========================================
Files 42 42
Lines 4561 4569 +8
Branches 369 371 +2
==========================================
+ Hits 4238 4248 +10
+ Misses 321 319 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
I've also discovered that not just my new ui breaks in horizontal mode on mobile, but all the other ui too, so I think, that fixing that should be a different pr, as this one is already getting quite big. I can take care of fixing that later on in a different pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @KyleKlus!
This pr implements the ability to open the views (deck view and card view) of the sr plugin in a tab/window, rather than in a modal. This ability is turned off by default and can be turned on via a toggle in the ui settings of the sr plugin.
Further more one can also limit the size of the ui within a tab via the already existing flashcard size setting.
This should also satisfy the issues #819, #950 and #1180 partly, but I can also add the open file in new tab button, if that is alright with you, as I've already implemented that on an unpublished branch.
The deck list in a tab
A card in a tab
New setting in the "User Interface" tab