Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option for viewing sr decks and cards in tabs #1169

Merged
merged 16 commits into from
Dec 24, 2024

Conversation

KyleKlus
Copy link
Contributor

@KyleKlus KyleKlus commented Nov 17, 2024

This pr implements the ability to open the views (deck view and card view) of the sr plugin in a tab/window, rather than in a modal. This ability is turned off by default and can be turned on via a toggle in the ui settings of the sr plugin.
Further more one can also limit the size of the ui within a tab via the already existing flashcard size setting.

This should also satisfy the issues #819, #950 and #1180 partly, but I can also add the open file in new tab button, if that is alright with you, as I've already implemented that on an unpublished branch.

image
The deck list in a tab

image
A card in a tab

image
New setting in the "User Interface" tab

@KyleKlus KyleKlus changed the title [FEAT]: Tabbed view feat: Option for viewing plugin in tabs Nov 17, 2024
@KyleKlus KyleKlus changed the title feat: Option for viewing plugin in tabs feat: Option for viewing sr decks and cards in tabs Nov 20, 2024
@KyleKlus
Copy link
Contributor Author

Please dont merge it just yet; I have discovered, that the button alignment breaks, if one tilts the phone into horizontal mode 😅

@KyleKlus KyleKlus marked this pull request as draft November 25, 2024 13:26
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (8359918) to head (bc81a22).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1169      +/-   ##
==========================================
+ Coverage   92.91%   92.97%   +0.05%     
==========================================
  Files          42       42              
  Lines        4561     4569       +8     
  Branches      369      371       +2     
==========================================
+ Hits         4238     4248      +10     
+ Misses        321      319       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KyleKlus
Copy link
Contributor Author

KyleKlus commented Dec 2, 2024

I've also discovered that not just my new ui breaks in horizontal mode on mobile, but all the other ui too, so I think, that fixing that should be a different pr, as this one is already getting quite big.

I can take care of fixing that later on in a different pr.

@KyleKlus KyleKlus marked this pull request as ready for review December 2, 2024 15:29
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @KyleKlus!

@st3v3nmw st3v3nmw merged commit 79536e6 into st3v3nmw:master Dec 24, 2024
4 checks passed
@KyleKlus KyleKlus deleted the tabbed-view branch December 25, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants