Only hashing immutable part of network configuration for dataDir ID #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Dec 19, 2024
Comment on lines
+175
to
+178
| if conf.rewriteDatadirId: | ||
| writeDataDirId(kvt, calculatedId) | ||
| return | ||
|
|
There was a problem hiding this comment.
Wouldn't this allow it to write an existing holesky database with sepolia config when the flag is passed? Misconfiguration issue from users POV, but better if prevented
There was a problem hiding this comment.
and how to prevent that?
There was a problem hiding this comment.
Maybe storing networkId and networkParams separately 🤔, instead of hashing them together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mjfh; @agnxsh ; @arnetheduck you can use hidden config
--rewrite-datadir-idto reconfigure your existing database if you encounter "Data dir already initialized with other network configuration"Future hardfork time or in the case of holesky and mainnet, got new
depositContractAddressmake the network configuration can change when new features added.Because we need something stable to identify dataDir with network configuration, the new dataDir ID is calculated using only immutable parts of network configuration.