feat: fr32-sha2-256-trunc254-padded-binary-tree #19
Conversation
| const root = parseLink(data.out.cid).multihash.digest | ||
| const height = Piece.PaddedSize.toHeight(BigInt(data.out.paddedSize)) | ||
|
|
||
| { |
There was a problem hiding this comment.
Why are using brackets here?
There was a problem hiding this comment.
Just creating scopes so I don't have to come up with three different names for digest. It also kind of provides some separation, but if this is confusing I can remove them and call digest1, digest2.
I might actually generate separate test functions instead.
src/multihash.js
Outdated
| export const MAX_HEIGHT = 255 | ||
|
|
||
| /** | ||
| * Given that max size of the |
There was a problem hiding this comment.
Oops not sure what happened here
| if (asMultihash) { | ||
| output.set(PREFIX, byteOffset) | ||
| byteOffset += PREFIX.length | ||
| } |
There was a problem hiding this comment.
nit: I would have a new function to do so. Thoughts?
Otherwise, the byteOffset being optional is also tricky as it is required to use third param. Perhaps having an object for options?
There was a problem hiding this comment.
You mean have a separate function that encodes multihash prefix ? I mostly wanted to align it with StreamingHasher interface implemented by blake3-multihash
That said you are right interface is bit clunky. I have created multiformats/js-multiformats#260 so we could uplift the incremental hasher into multiformats. How about we iterate on the interface there and then we can reflect consensus here in a followup.
🤖 I have created a release *beep* *boop* --- ## [2.2.0](v2.1.0...v2.2.0) (2023-07-21) ### Features * fr32-sha2-256-trunc254-padded-binary-tree ([412bf18](412bf18)) * fr32-sha2-256-trunc254-padded-binary-tree ([#19](#19)) ([0c7b499](0c7b499)) * padded size from height calc function ([dba6cd5](dba6cd5)) * padded size from height calc function ([#18](#18)) ([47971cd](47971cd)) ### Bug Fixes * export interface for data structure with link and height ([263656e](263656e)) * export interface for data structure with link and height ([#17](#17)) ([a1006c0](a1006c0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.