Allow specifying the maximum song title length before scrolling begins in spotify-widget #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows specifying a max title length before the widget begins to scroll it If -1 is specified, the widget will never scroll (similar to max_length) Note that ONLY the song title will ever scroll and so the maximum length is only in respect to the song length, not the overall content length. (this is the pre-existing behavior which has not been touched in this PR)
Allows specifying the max length before song titles begin scrolling via widget config. Much like with the max_length config option, a value of -1 will be uncapped.
Fixed up a spelling error and documented the -1 behavior. The -1 behavior is obviously intended, because it was already demonstrated in one of the examples.
|
This looks cool! Thanks! I would like to test it for some time (I'm not 100% sure about using scrollable widget, as there was some note in docs about how resource-greedy it might be - not sure, though, if it's still the case if widget does not scroll) |
|
@streetturtle The widget already scrolls, though. I actually introduced this PR specifically because I hated the scrolling and wanted a way to turn it off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows specifying a max title length via a new
title_scroll_lengthoption before spotify-widget begins scrolling it. If -1 is specified, the widget will never scroll (this is also how the pre-existingmax_lengthconfiguration option works works). The originally hardcoded maximum scroll area width has been retained as the default option value.Note that only the song title is ever scrolled by the widget (this is the pre-existing behavior) and so only the length of the title will count towards the scroll area length.