mock: update callString to format context.Context as pointer #1689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes updating
func callString
inpackage mock
to formatcontext.Context
arguments as their pointer value, in order to avoid a data race from formatting the internals as a string.Changes
func callString
to formatcontext.Context
args as their pointer valueTest_callString/context
to validateMotivation
This is an example race detected from the new test
Test_callString/context
, before including the fix:Data Race