-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] Service to load data from different sources #641
Draft
MacFJA
wants to merge
5
commits into
v2
Choose a base branch
from
v2-service
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This PR add "service" to load data from sources (internal and external).
Implemented source:
Usage
Server side
The input data is minimal: the type of data and an identifier.
Each source will be interrogated if it can handle the data
Note
CollectorService is a service that aggregate all main service
All services will be asked if they can handle a
package
, that can be found with anidentifier
(so Youtube service will respond immediately that it can't andpackage
)Tip
All methods that request external resource or take time to compute can be cached with the addition of a simple decorator (
@Memorize(cacheStorage)
) to reduce lantencyRender side
To display a data from the services, there are 5 components:
All components are design to accept the same parameter as the result of the services, so using them is simple: +page.svelte
Footnotes
There is no public API, the probability that the current code won't work in a near future is pretty high 😞 ↩
Need to be connected to the database ↩ ↩2