Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: incorporate <svelte:html> into templates #365

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Dec 18, 2024

Related to sveltejs/kit#13065

TBH I don't love the fact that it's one more file for the minimal template and the library template, but it is what it is - and it scales much better.

Can only be merged after the related PR and the one in Svelte chore is actually released

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 9be2d95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/create Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 18, 2024

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@365
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@365

commit: 9be2d95

@manuel3108
Copy link
Member

Marking as draft, as the other PR are drafts too, and have received at least some pushback. We cannot merge this without the other PRs.

@manuel3108 manuel3108 marked this pull request as draft December 23, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants