-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use rolldown
#371
base: main
Are you sure you want to change the base?
chore: use rolldown
#371
Conversation
|
I get I also don't see any changes happening when I modify a file on Linux. Or at least nothing printed to the screen. I modified a file to have syntax errors and the screen didn't change at all |
I noticed this is outputting sourcemaps. Do we need those? The package would probably be a lot lighter without them. No idea if it might also speed up compile times |
Thanks for the confirmation. Identified the root issue (having more than 5 projects breaks watch mode, we have 6) and thus opened an upstream issue: rolldown/rolldown#3214
This is also happening with our last release and seems to be the cause for about 50% of our bundle size. Investigating (#373) |
Awesome detective work. Personally I don't really use |
Update to the |
Looks like there's a merge conflict |
Previous work #11
In contrast to my last try a few weeks ago, the conversion seems to be nearly flawless. Since
rolldown
is nearing a 1.0 release, i thought we could reconsider our decisionApart from the watch mode, everything seems to be working flawlessly. As for the watch mode I either made a configuration mistake, or there is an upstream bug. Every time I start the watch mode I get the following output:
Modifying any of the related files does not trigger a rebuild though. Maybe someone can test this on a unix system to see if it's windows related. Surprisingly noone seems to be using watch mode in a public github repository: https://github.com/search?q=%22rolldown+-w%22+OR+%22rolldown+--watch%22+path%3A**%2Fpackage.json&type=code&ref=advsearch