Editorial: Handle case when backzone doesn't contain link #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of links aren't in `backzone`. Change the assertion to an if-step to correctly handle this case. List of time zones which weren't correctly handled: ``` Africa/Kinshasa Africa/Lubumbashi America/Atikokan America/Blanc-Sablon America/Creston Antarctica/DumontDUrville Antarctica/McMurdo Antarctica/Syowa Asia/Kuala_Lumpur Europe/Busingen Pacific/Chuuk Pacific/Majuro Pacific/Midway Pacific/Pohnpei Pacific/Wake ``` For example "Africa/Kinshasa", which is a zone in `backzone`: - "Africa/Kinshasa" is a link to "Africa/Lagos" per `backward`. - The region code for "Africa/Lagos" is "NG", the region code for "Africa/Kinshasa" is "CD". That means the condition in step 5.b.iii.3 evaluates to false. - There are two entries for the region "CD" in `zone.tab`: "Africa/Kinshasa" and "Africa/Lubumbashi". That means the condition in step 5.b.iii.4.b also evaluates to false. - "Africa/Kinshasa" is a zone in `backzone`, so the loop in step 5.b.iii.4.c.iii won't find any entries. All other cases are also zones in `backzone`, except for "Europe/Busingen", which is always a link. "Europe/Busingen" links to "Europe/Zurich" per `backward`, but is still a primary identifier in ECMA-402, because Büsingen is politically a part of Germany, so it shouldn't be merged with the time zone for Zürich (Switzerland).
|
Hmmm, I'm not sure I understand the problem. Could you clarify? The current spec in says at 5b:
If the identifier is in zone.tab, then it's a primary identifier and we never have to look in backzone. The only purpose of the backzone logic is to handle links that aren't in zone.tab. |
|
Whoops, seems like I've skipped over the "[...] identifier is not present in the “TZ” column of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of links aren't in
backzone. Change the assertion to an if-step to correctly handle this case.List of time zones which weren't correctly handled:
For example "Africa/Kinshasa", which is a zone in
backzone:backward.zone.tab: "Africa/Kinshasa" and "Africa/Lubumbashi". That means the condition in step 5.b.iii.4.b also evaluates to false.backzone, so the loop in step 5.b.iii.4.c.iii won't find any entries.All other cases are also zones in
backzone, except for "Europe/Busingen", which is always a link. "Europe/Busingen" links to "Europe/Zurich" perbackward, but is still a primary identifier in ECMA-402, because Büsingen is politically a part of Germany, so it shouldn't be merged with the time zone for Zürich (Switzerland).