Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature tag for async-iterator-helpers #4356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anba
Copy link
Contributor

@anba anba commented Dec 18, 2024

The tests in "staging/sm/AsyncIterator" incorrectly use "async-iteration" (which is the feature tag for async function*). A new feature tag is needed for https://github.com/tc39/proposal-async-iterator-helpers.

@anba anba requested review from a team as code owners December 18, 2024 09:12
@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 18, 2024

Thanks for flagging this. What stage is this proposal at? If it's too early, I'd need to skip them instead.

@anba
Copy link
Contributor Author

anba commented Dec 18, 2024

It's a stage 2 proposal.

@Ms2ger Ms2ger mentioned this pull request Dec 18, 2024
@ljharb
Copy link
Member

ljharb commented Dec 18, 2024

should this PR also be updating the feature flag used in the relevant staging tests?

@anba
Copy link
Contributor Author

anba commented Dec 18, 2024

should this PR also be updating the feature flag used in the relevant staging tests?

#4354 should cover updating the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants