Replace redundant trait bounds with Model #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not required anymore as of version 2 of the mongodb rust driver.
|
Could you merge this and publish it to crates.io? Even doing something like a |
|
Will this be merged? When will this and #89 be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as discussed in #89.
I replaced the bounds of the form
Model + Xwith justModel. In theModeltrait I wrote a sentence of documentation explaining why the additional trait bounds are needed.In the
ModelCursorstruct, instead of writing out the bounds required forCursor, I restricted the whole struct toModel. That made sense to me, because aModelCursorseems to be designed to be used with aModel.I also removed the
PhantomDatafromModelCursor, since the generic typeTis now used in theCursor.I additionally added a few characters of documentation stating that we now also test against mongodb 5, and I ran
cargo update.