Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use r_base::%in% #292

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: Use r_base::%in% #292

wants to merge 4 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Oct 27, 2024

No description provided.

@krlmlr krlmlr changed the title DRAFT feat: Use r_base::%in% Oct 27, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b3e03aa is merged into main:

  • 🚀001_tpch_01: 25.1ms -> 22.1ms [-15.99%, -8.09%]
  • 🚀001_tpch_02: 132ms -> 128ms [-4.43%, -1.09%]
  • 🚀001_tpch_03: 69.9ms -> 68.2ms [-4.54%, -0.25%]
  • 🚀001_tpch_04: 24.9ms -> 23.3ms [-8.06%, -4.76%]
  • 🚀001_tpch_05: 127ms -> 123ms [-5.03%, -1.17%]
  • ❗🐌001_tpch_06: 15.8ms -> 18.4ms [+13.11%, +19.02%]
  • 🚀001_tpch_07: 144ms -> 136ms [-7.02%, -4.5%]
  • 🚀001_tpch_08: 166ms -> 158ms [-6.48%, -3.17%]
  • 🚀001_tpch_09: 136ms -> 133ms [-2.93%, -0.22%]
  • 🚀001_tpch_10: 79.3ms -> 75.8ms [-6.13%, -2.69%]
  • 🚀001_tpch_11: 68ms -> 30.7ms [-56.99%, -52.78%]
  • 🚀001_tpch_12: 62.1ms -> 19.8ms [-70.35%, -65.82%]
  • ❗🐌001_tpch_13: 20.7ms -> 24.5ms [+15.55%, +21.01%]
  • ❗🐌001_tpch_14: 22ms -> 23.5ms [+4.09%, +9%]
  • 🚀001_tpch_15: 67ms -> 29ms [-59.21%, -54.22%]
  • 🚀001_tpch_16: 68.2ms -> 25ms [-65.11%, -61.55%]
  • 🚀001_tpch_17: 28.6ms -> 25.6ms [-12.58%, -8.38%]
  • 🚀001_tpch_18: 24.8ms -> 23.2ms [-9.59%, -3.44%]
  • 🚀001_tpch_19: 135ms -> 60.3ms [-56.86%, -53.85%]
  • 🚀001_tpch_20: 83.5ms -> 78.2ms [-8.83%, -3.88%]
  • 🚀001_tpch_21: 182ms -> 106ms [-43.11%, -39.91%]
  • 🚀001_tpch_22: 130ms -> 26.8ms [-80.8%, -78.18%]
  • 🚀010_tpch_01: 84.5ms -> 79.8ms [-10.96%, -0.14%]
  • 🚀010_tpch_02: 72.3ms -> 69.9ms [-5.36%, -1.14%]
  • 🚀010_tpch_03: 67.4ms -> 63.1ms [-8.55%, -4.36%]
  • ✔️010_tpch_04: 50.3ms -> 49.1ms [-5.55%, +1.04%]
  • 🚀010_tpch_05: 95.7ms -> 91.8ms [-5.6%, -2.57%]
  • 🚀010_tpch_06: 36.2ms -> 32.5ms [-16.26%, -4.1%]
  • 🚀010_tpch_07: 116ms -> 105ms [-12.4%, -6.74%]
  • 🚀010_tpch_08: 136ms -> 128ms [-7.96%, -3.83%]
  • 🚀010_tpch_09: 121ms -> 116ms [-8.26%, -0.24%]
  • 🚀010_tpch_10: 86.1ms -> 81.3ms [-7.76%, -3.44%]
  • 🚀010_tpch_11: 39ms -> 36.2ms [-10.04%, -4.28%]
  • 🚀010_tpch_12: 64.3ms -> 53.5ms [-19.33%, -14.14%]
  • ✔️010_tpch_13: 55.3ms -> 51.6ms [-13.58%, +0.15%]
  • 🚀010_tpch_14: 43ms -> 37.4ms [-15%, -11%]
  • 🚀010_tpch_15: 60.5ms -> 57ms [-9.75%, -2.06%]
  • 🚀010_tpch_16: 45.1ms -> 33.1ms [-28.91%, -24.31%]
  • 🚀010_tpch_17: 57.5ms -> 54.6ms [-9.48%, -0.38%]
  • ✔️010_tpch_18: 58.4ms -> 54.4ms [-16.56%, +2.81%]
  • 🚀010_tpch_19: 126ms -> 72ms [-43.53%, -41.89%]
  • 🚀010_tpch_20: 73.4ms -> 68.1ms [-9.19%, -5.04%]
  • 🚀010_tpch_21: 430ms -> 385ms [-12.9%, -7.69%]
  • 🚀010_tpch_22: 79.3ms -> 32.9ms [-60.4%, -56.59%]
  • ✔️100_tpch_01: 1.22s -> 1.24s [-2.65%, +6.06%]
  • ✔️100_tpch_02: 123ms -> 124ms [-8.7%, +10.93%]
  • ✔️100_tpch_03: 1.1s -> 1.11s [-3.08%, +4.91%]
  • ✔️100_tpch_04: 1.08s -> 1.08s [-2.88%, +2.15%]
  • ✔️100_tpch_05: 1.19s -> 1.18s [-3.19%, +1.33%]
  • ✔️100_tpch_06: 1.01s -> 1s [-5.87%, +3.99%]
  • ✔️100_tpch_07: 1.14s -> 1.16s [-2.23%, +5.6%]
  • ✔️100_tpch_08: 1.16s -> 1.19s [-1.62%, +7%]
  • ✔️100_tpch_09: 1.28s -> 1.26s [-4.76%, +1.89%]
  • ✔️100_tpch_10: 1.14s -> 1.14s [-2.82%, +3.32%]
  • 🚀100_tpch_11: 82.2ms -> 77.7ms [-9.51%, -1.31%]
  • ✔️100_tpch_12: 1.1s -> 1.11s [-1.23%, +3.02%]
  • ✔️100_tpch_13: 329ms -> 335ms [-9.06%, +13.07%]
  • ✔️100_tpch_14: 1.04s -> 1.06s [-0.56%, +3.46%]
  • ✔️100_tpch_15: 1.14s -> 1.12s [-4.22%, +1.82%]
  • 🚀100_tpch_16: 126ms -> 109ms [-20.81%, -6.84%]
  • ✔️100_tpch_17: 1.08s -> 1.09s [-2.08%, +4.67%]
  • ✔️100_tpch_18: 1.12s -> 1.12s [-3.76%, +5.11%]
  • 🚀100_tpch_19: 1.2s -> 1.17s [-5.18%, -0.09%]
  • ✔️100_tpch_20: 1.1s -> 1.1s [-2.3%, +3.64%]
  • ✔️100_tpch_21: 2.25s -> 2.22s [-7.23%, +3.78%]
  • 🚀100_tpch_22: 176ms -> 77.1ms [-61.02%, -51.25%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr
Copy link
Member Author

krlmlr commented Nov 10, 2024

Blocked by hannes/duckdb-rfuns#113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant