Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Client-side warning on join explosion #325

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Client-side warning on join explosion #325

wants to merge 1 commit into from
+82 −15

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 4, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a1a2dab is merged into main:

  • ✔️001_tpch_01: 24.7ms -> 25.1ms [-2.24%, +5.33%]
  • ❗🐌001_tpch_02: 129ms -> 168ms [+29.11%, +32.63%]
  • ❗🐌001_tpch_03: 67.8ms -> 125ms [+82.31%, +85.54%]
  • ❗🐌001_tpch_04: 24.8ms -> 66.9ms [+166.9%, +173.22%]
  • 🚀001_tpch_05: 125ms -> 113ms [-11.52%, -8.1%]
  • ✔️001_tpch_06: 15.9ms -> 15.9ms [-3.42%, +3.41%]
  • 🚀001_tpch_07: 142ms -> 135ms [-5.88%, -3.97%]
  • ❗🐌001_tpch_08: 163ms -> 200ms [+21.75%, +24.06%]
  • 🚀001_tpch_09: 133ms -> 119ms [-12.75%, -9.36%]
  • ❗🐌001_tpch_10: 78.2ms -> 145ms [+82.76%, +87.32%]
  • ❗🐌001_tpch_11: 64.7ms -> 133ms [+103.63%, +107.77%]
  • ❗🐌001_tpch_12: 59.7ms -> 74.4ms [+22.42%, +26.93%]
  • ❗🐌001_tpch_13: 20.6ms -> 25.2ms [+18.67%, +25.7%]
  • ❗🐌001_tpch_14: 22.3ms -> 64.4ms [+183.9%, +192.79%]
  • ❗🐌001_tpch_15: 64.9ms -> 87.2ms [+32.27%, +36.62%]
  • ❗🐌001_tpch_16: 66.9ms -> 80.7ms [+18.55%, +22.73%]
  • ❗🐌001_tpch_17: 28.1ms -> 76ms [+166.6%, +174.62%]
  • ❗🐌001_tpch_18: 24.1ms -> 68.5ms [+180.77%, +188.6%]
  • ❗🐌001_tpch_19: 129ms -> 141ms [+8.91%, +10.3%]
  • ❗🐌001_tpch_20: 81.8ms -> 143ms [+71.18%, +77.18%]
  • ❗🐌001_tpch_21: 179ms -> 209ms [+15.27%, +18.81%]
  • ❗🐌001_tpch_22: 129ms -> 139ms [+6.22%, +9.36%]
  • ✔️010_tpch_01: 86.9ms -> 82.8ms [-11.96%, +2.57%]
  • ❗🐌010_tpch_02: 75.5ms -> 126ms [+62.33%, +71.24%]
  • ❗🐌010_tpch_03: 69.7ms -> 127ms [+74.07%, +90.06%]
  • ❗🐌010_tpch_04: 52.7ms -> 91.8ms [+66.98%, +81.43%]
  • ❗🐌010_tpch_05: 99.6ms -> 203ms [+98.48%, +109.91%]
  • ✔️010_tpch_06: 36.8ms -> 36.6ms [-6.55%, +5.13%]
  • ❗🐌010_tpch_07: 116ms -> 221ms [+85.65%, +93.95%]
  • ❗🐌010_tpch_08: 137ms -> 322ms [+130.95%, +137.06%]
  • ❗🐌010_tpch_09: 120ms -> 223ms [+81.24%, +88.72%]
  • ❗🐌010_tpch_10: 89ms -> 169ms [+84.08%, +95.45%]
  • ❗🐌010_tpch_11: 39.5ms -> 90.2ms [+123.26%, +134.1%]
  • ❗🐌010_tpch_12: 62.9ms -> 117ms [+80.5%, +90.5%]
  • ❗🐌010_tpch_13: 54.5ms -> 59.2ms [+4.68%, +12.26%]
  • ❗🐌010_tpch_14: 41.8ms -> 66.6ms [+54.02%, +64.65%]
  • ❗🐌010_tpch_15: 61ms -> 130ms [+107.05%, +119.68%]
  • ❗🐌010_tpch_16: 47.1ms -> 67.8ms [+37.76%, +50.01%]
  • ❗🐌010_tpch_17: 59.9ms -> 116ms [+88.17%, +100.44%]
  • ❗🐌010_tpch_18: 56.1ms -> 106ms [+81.98%, +95.76%]
  • ❗🐌010_tpch_19: 124ms -> 157ms [+23.41%, +28.56%]
  • ❗🐌010_tpch_20: 75.7ms -> 125ms [+59.86%, +69.88%]
  • ❗🐌010_tpch_21: 426ms -> 735ms [+69.16%, +75.92%]
  • ❗🐌010_tpch_22: 79.2ms -> 93.9ms [+15.44%, +21.67%]
  • ✔️100_tpch_01: 1.22s -> 1.19s [-6.71%, +2.72%]
  • ❗🐌100_tpch_02: 124ms -> 262ms [+86.56%, +133.64%]
  • ❗🐌100_tpch_03: 1.07s -> 1.29s [+18.7%, +22.06%]
  • ❗🐌100_tpch_04: 1.06s -> 1.23s [+13.37%, +19.84%]
  • ❗🐌100_tpch_05: 1.17s -> 1.54s [+29.05%, +33.52%]
  • ✔️100_tpch_06: 990ms -> 1.01s [-0.69%, +4.62%]
  • ❗🐌100_tpch_07: 1.14s -> 1.51s [+30.5%, +34.89%]
  • ❗🐌100_tpch_08: 1.16s -> 1.83s [+53.78%, +62.61%]
  • ❗🐌100_tpch_09: 1.25s -> 1.85s [+40.81%, +54.34%]
  • ❗🐌100_tpch_10: 1.14s -> 1.42s [+19.33%, +30.36%]
  • ❗🐌100_tpch_11: 83.1ms -> 236ms [+159.48%, +209.16%]
  • ❗🐌100_tpch_12: 1.11s -> 1.33s [+15.78%, +23.1%]
  • ✔️100_tpch_13: 361ms -> 374ms [-0.85%, +7.9%]
  • ❗🐌100_tpch_14: 1.05s -> 1.12s [+5.14%, +7.82%]
  • ❗🐌100_tpch_15: 1.12s -> 1.4s [+23.79%, +27.03%]
  • ❗🐌100_tpch_16: 124ms -> 176ms [+34.4%, +50.54%]
  • 🚀100_tpch_17: 1.05s -> 558ms [-49%, -45.03%]
  • ❗🐌100_tpch_18: 1.1s -> 1.34s [+19.18%, +24.19%]
  • 🚀100_tpch_19: 1.2s -> 569ms [-56.73%, -48.1%]
  • ❗🐌100_tpch_20: 1.08s -> 1.24s [+12.99%, +16.77%]
  • ❗🐌100_tpch_21: 2.23s -> 4.54s [+94.2%, +113.75%]
  • ❗🐌100_tpch_22: 193ms -> 236ms [+10.46%, +33.83%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr force-pushed the f-join-multi-detect branch from a1a2dab to 2cb895e Compare November 11, 2024 05:27
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2cb895e is merged into main:

  • ✔️001_tpch_01: 23.9ms -> 24.6ms [-0.69%, +6.58%]
  • ❗🐌001_tpch_02: 129ms -> 167ms [+27.24%, +31.47%]
  • ❗🐌001_tpch_03: 66.8ms -> 155ms [+129.47%, +134.05%]
  • ❗🐌001_tpch_04: 24ms -> 67ms [+176.64%, +182.43%]
  • 🚀001_tpch_05: 122ms -> 106ms [-13.99%, -11.92%]
  • ✔️001_tpch_06: 15ms -> 15.1ms [-1.46%, +2.18%]
  • 🚀001_tpch_07: 145ms -> 133ms [-9.64%, -7.34%]
  • ❗🐌001_tpch_08: 168ms -> 195ms [+14.96%, +17.24%]
  • 🚀001_tpch_09: 146ms -> 124ms [-16.27%, -13.43%]
  • ❗🐌001_tpch_10: 85.8ms -> 159ms [+82.53%, +87.05%]
  • ❗🐌001_tpch_11: 71.9ms -> 146ms [+100.5%, +106.35%]
  • ❗🐌001_tpch_12: 31ms -> 84.1ms [+167.49%, +175.89%]
  • ❗🐌001_tpch_13: 21.8ms -> 27.1ms [+21.83%, +27.26%]
  • ❗🐌001_tpch_14: 23.3ms -> 71.6ms [+203.84%, +212.14%]
  • ❗🐌001_tpch_15: 73.7ms -> 98.4ms [+30.96%, +36%]
  • ❗🐌001_tpch_16: 72.9ms -> 88.2ms [+18.82%, +23.4%]
  • ❗🐌001_tpch_17: 27.6ms -> 75.8ms [+168.81%, +180.14%]
  • ❗🐌001_tpch_18: 23.4ms -> 68.6ms [+189.09%, +196.85%]
  • ❗🐌001_tpch_19: 131ms -> 143ms [+7.49%, +10.21%]
  • ❗🐌001_tpch_20: 79ms -> 171ms [+114.55%, +119.51%]
  • ❗🐌001_tpch_21: 175ms -> 205ms [+15.36%, +17.93%]
  • ❗🐌001_tpch_22: 131ms -> 139ms [+4.43%, +8.16%]
  • ✔️010_tpch_01: 82.6ms -> 81.5ms [-4.56%, +1.82%]
  • ❗🐌010_tpch_02: 71.3ms -> 122ms [+67.07%, +76.17%]
  • ❗🐌010_tpch_03: 65.6ms -> 119ms [+76%, +86.29%]
  • ❗🐌010_tpch_04: 48.9ms -> 90.6ms [+80.73%, +90.28%]
  • ❗🐌010_tpch_05: 97.5ms -> 193ms [+93.08%, +102.18%]
  • ✔️010_tpch_06: 37.2ms -> 36.6ms [-10.44%, +7.17%]
  • ❗🐌010_tpch_07: 116ms -> 217ms [+82.61%, +92.45%]
  • ❗🐌010_tpch_08: 133ms -> 310ms [+130.87%, +135.87%]
  • ❗🐌010_tpch_09: 119ms -> 218ms [+79.79%, +86.96%]
  • ❗🐌010_tpch_10: 84.8ms -> 163ms [+89.43%, +95.78%]
  • ❗🐌010_tpch_11: 38.7ms -> 85.9ms [+118.17%, +125.8%]
  • ❗🐌010_tpch_12: 62.3ms -> 113ms [+78.65%, +83.19%]
  • ❗🐌010_tpch_13: 53.7ms -> 58ms [+4.62%, +11.48%]
  • ❗🐌010_tpch_14: 42ms -> 63.4ms [+48.89%, +52.99%]
  • ❗🐌010_tpch_15: 59.3ms -> 134ms [+116.97%, +134.11%]
  • ❗🐌010_tpch_16: 45.4ms -> 65.9ms [+42.15%, +48.32%]
  • ❗🐌010_tpch_17: 57ms -> 116ms [+95.75%, +111.24%]
  • ❗🐌010_tpch_18: 56.5ms -> 104ms [+77.84%, +92.12%]
  • ❗🐌010_tpch_19: 124ms -> 154ms [+23.21%, +26.25%]
  • ❗🐌010_tpch_20: 74.2ms -> 122ms [+59.66%, +68.72%]
  • ❗🐌010_tpch_21: 434ms -> 746ms [+70.04%, +73.68%]
  • ❗🐌010_tpch_22: 78.3ms -> 94ms [+17.57%, +22.53%]
  • ✔️100_tpch_01: 1.2s -> 1.24s [-0.96%, +7.34%]
  • ❗🐌100_tpch_02: 121ms -> 254ms [+100.7%, +117.88%]
  • ❗🐌100_tpch_03: 1.1s -> 1.31s [+16.46%, +21.55%]
  • ❗🐌100_tpch_04: 1.07s -> 1.24s [+13.28%, +17.86%]
  • ❗🐌100_tpch_05: 1.18s -> 1.54s [+27.42%, +33.82%]
  • ✔️100_tpch_06: 1.03s -> 1.02s [-2.86%, +2.33%]
  • ❗🐌100_tpch_07: 1.15s -> 1.51s [+29.07%, +32.66%]
  • ❗🐌100_tpch_08: 1.17s -> 1.86s [+55.97%, +61.95%]
  • ❗🐌100_tpch_09: 1.25s -> 1.88s [+47.3%, +53.22%]
  • ❗🐌100_tpch_10: 1.13s -> 1.42s [+21.73%, +29.72%]
  • ❗🐌100_tpch_11: 87.4ms -> 230ms [+139.76%, +187.74%]
  • ❗🐌100_tpch_12: 1.12s -> 1.33s [+15.83%, +21.58%]
  • ❗🐌100_tpch_13: 317ms -> 335ms [+0.38%, +10.96%]
  • ❗🐌100_tpch_14: 1.04s -> 1.13s [+7.41%, +10.6%]
  • ❗🐌100_tpch_15: 1.13s -> 1.45s [+24.96%, +30.38%]
  • ❗🐌100_tpch_16: 122ms -> 177ms [+37.9%, +52.89%]
  • 🚀100_tpch_17: 1.08s -> 542ms [-51.04%, -48.49%]
  • ❗🐌100_tpch_18: 1.11s -> 1.36s [+20.94%, +24.39%]
  • 🚀100_tpch_19: 1.22s -> 571ms [-55.66%, -50.47%]
  • ❗🐌100_tpch_20: 1.1s -> 1.27s [+11.35%, +19.36%]
  • ❗🐌100_tpch_21: 2.23s -> 4.51s [+97.55%, +107.14%]
  • ❗🐌100_tpch_22: 177ms -> 229ms [+20.96%, +37.95%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr force-pushed the f-join-multi-detect branch from 2cb895e to 88bd29f Compare December 14, 2024 14:00
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 88bd29f is merged into main:

  • ✔️001_tpch_01: 25.5ms -> 25.9ms [-2.94%, +5.75%]
  • ❗🐌001_tpch_02: 138ms -> 177ms [+27.47%, +28.94%]
  • ❗🐌001_tpch_03: 73.3ms -> 169ms [+129.31%, +131.84%]
  • ❗🐌001_tpch_04: 24.8ms -> 71.8ms [+186.39%, +191.53%]
  • 🚀001_tpch_05: 131ms -> 113ms [-14.92%, -13.46%]
  • ✔️001_tpch_06: 16.3ms -> 16.4ms [-2.82%, +3.72%]
  • 🚀001_tpch_07: 151ms -> 136ms [-10.88%, -8.66%]
  • ❗🐌001_tpch_08: 171ms -> 197ms [+14.15%, +16.27%]
  • 🚀001_tpch_09: 142ms -> 120ms [-16.62%, -14.47%]
  • ❗🐌001_tpch_10: 82.3ms -> 151ms [+82.47%, +85.63%]
  • ❗🐌001_tpch_11: 71.1ms -> 180ms [+150.57%, +154.95%]
  • ❗🐌001_tpch_12: 29.8ms -> 79.5ms [+164.52%, +169.28%]
  • ❗🐌001_tpch_13: 21.3ms -> 26.1ms [+20.47%, +25.08%]
  • ❗🐌001_tpch_14: 22.3ms -> 68.3ms [+203.77%, +209.03%]
  • ❗🐌001_tpch_15: 70.7ms -> 93.4ms [+30.85%, +33.58%]
  • ❗🐌001_tpch_16: 71.8ms -> 87.1ms [+19.99%, +22.72%]
  • ❗🐌001_tpch_17: 28.8ms -> 81.6ms [+181.33%, +185.74%]
  • ❗🐌001_tpch_18: 25.1ms -> 75.6ms [+198.91%, +204.82%]
  • ❗🐌001_tpch_19: 139ms -> 153ms [+8.9%, +10.59%]
  • ❗🐌001_tpch_20: 84.7ms -> 185ms [+117.27%, +120.25%]
  • ❗🐌001_tpch_21: 190ms -> 217ms [+13.81%, +15.12%]
  • ❗🐌001_tpch_22: 137ms -> 147ms [+6.36%, +7.83%]
  • ✔️010_tpch_01: 85.3ms -> 84.5ms [-4.42%, +2.67%]
  • ❗🐌010_tpch_02: 74.9ms -> 130ms [+68.81%, +78.09%]
  • ❗🐌010_tpch_03: 67.6ms -> 119ms [+73.96%, +79.34%]
  • ❗🐌010_tpch_04: 48.1ms -> 87.3ms [+77.89%, +85.02%]
  • ❗🐌010_tpch_05: 98.1ms -> 203ms [+102.76%, +112.12%]
  • ✔️010_tpch_06: 38.7ms -> 37.5ms [-11.38%, +5.21%]
  • ❗🐌010_tpch_07: 115ms -> 219ms [+87.07%, +94.3%]
  • ❗🐌010_tpch_08: 137ms -> 323ms [+133.8%, +138.29%]
  • ❗🐌010_tpch_09: 126ms -> 229ms [+78.81%, +84.36%]
  • ❗🐌010_tpch_10: 82ms -> 156ms [+86.26%, +94.19%]
  • ❗🐌010_tpch_11: 40.1ms -> 92.2ms [+121.86%, +138.7%]
  • ❗🐌010_tpch_12: 62.4ms -> 116ms [+79.86%, +91.96%]
  • ❗🐌010_tpch_13: 54.9ms -> 59.9ms [+7.59%, +10.78%]
  • ❗🐌010_tpch_14: 42.3ms -> 65.3ms [+48.23%, +60.37%]
  • ❗🐌010_tpch_15: 58.6ms -> 129ms [+109.91%, +129.18%]
  • ❗🐌010_tpch_16: 46.6ms -> 68.7ms [+43.51%, +51.24%]
  • ❗🐌010_tpch_17: 59.2ms -> 124ms [+102.36%, +116.69%]
  • ❗🐌010_tpch_18: 59.2ms -> 117ms [+90.28%, +106.24%]
  • ❗🐌010_tpch_19: 122ms -> 156ms [+26.1%, +29.59%]
  • ❗🐌010_tpch_20: 74.6ms -> 121ms [+59.4%, +65.68%]
  • ❗🐌010_tpch_21: 405ms -> 752ms [+83.94%, +87.25%]
  • ❗🐌010_tpch_22: 81.1ms -> 97.9ms [+17.6%, +23.89%]
  • ✔️100_tpch_01: 1.27s -> 1.24s [-5.76%, +1.82%]
  • ❗🐌100_tpch_02: 129ms -> 267ms [+94.52%, +121.41%]
  • ❗🐌100_tpch_03: 1.11s -> 1.32s [+15.09%, +21.76%]
  • ❗🐌100_tpch_04: 1.08s -> 1.26s [+12.42%, +19.31%]
  • ❗🐌100_tpch_05: 1.2s -> 1.56s [+27.52%, +33.31%]
  • ✔️100_tpch_06: 1.02s -> 1.02s [-1.86%, +1.39%]
  • ❗🐌100_tpch_07: 1.16s -> 1.5s [+25.18%, +33.74%]
  • ❗🐌100_tpch_08: 1.2s -> 1.88s [+55.8%, +59.11%]
  • ❗🐌100_tpch_09: 1.28s -> 1.92s [+46.77%, +53.55%]
  • ❗🐌100_tpch_10: 1.14s -> 1.39s [+19.23%, +24.53%]
  • ❗🐌100_tpch_11: 85ms -> 245ms [+168.41%, +208.67%]
  • ❗🐌100_tpch_12: 1.11s -> 1.33s [+17.91%, +20.68%]
  • ✔️100_tpch_13: 351ms -> 356ms [-5.31%, +7.79%]
  • ❗🐌100_tpch_14: 1.05s -> 1.13s [+5.11%, +10.25%]
  • ❗🐌100_tpch_15: 1.12s -> 1.43s [+23.32%, +31.32%]
  • ❗🐌100_tpch_16: 129ms -> 195ms [+33.9%, +69.7%]
  • 🚀100_tpch_17: 1.1s -> 608ms [-50.11%, -39.34%]
  • ❗🐌100_tpch_18: 1.14s -> 1.38s [+19.42%, +21.97%]
  • 🚀100_tpch_19: 1.22s -> 592ms [-55.35%, -47.7%]
  • ❗🐌100_tpch_20: 1.09s -> 1.29s [+13.61%, +21.76%]
  • ❗🐌100_tpch_21: 2.36s -> 4.63s [+91.86%, +101.63%]
  • ❗🐌100_tpch_22: 175ms -> 228ms [+25.24%, +35.05%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krlmlr