Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5023.
Briefly, it exaggerates the radius value so that more segments are munched near small-r coordinates.
I've given the issue some thought and while I believe that the current calculation of the distance is correct, it does not quite match our intuition.
To compensate for this, in this PR I decided that 'correctness' of the distance calculation is subservient to looking good. To preserve distances at$R = 0$ and $R = 1$ , I've chosen $x^{0.75}$ as the method by which to boost smaller $R$ . It gives both small $R$ and big $R$ a boost, but proportionally this boosts small $R$ more. The formula is a subjective choice: I felt like $R$ without boosting big $R$ too much, but I like the simplicity of the current boosting.
sqrt(x)
was slightly too agressive. We could go with something likefunction(x, n = 3) x + n * (x^(1 / n) - x)^n
to boost smallerThis is a detail of the reprex in the linked issue with the current main branch:
This is a detail of the same area with this PR. You still see the angles, but it isn't as egregious.
Overall the entire grob went from having 61 points previously to 88 points now.