Use mprocessing config for evm report workers #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
approved these changes
Aug 24, 2021
|
Hmmm. This seems to be failing on an ethereum test (both runs, so it's probably not just a flaky test) https://github.com/trailofbits/manticore/pull/2481/checks?check_run_id=3415474758#step:6:80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the evm report workers default to using
multiprocessing.Processand ignore the--core.mprocessingconfig setting. This is not very desirable and can lead to issues such as #1715 on MacOS.This pull request fixes this and spawns the report workers correctly based on the
core.mprocessingsetting.